-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caloParams v0_4_2 and v0_4_3 #43046
Add caloParams v0_4_2 and v0_4_3 #43046
Conversation
…4_3 changing the UCC centrality intervals
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43046/37239
|
A new Pull Request was created by @mitaylor (Molly Taylor) for master. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Hi @mitaylor, we've been asked to stop putting these into central CMSSW (even though I was the person who led the charge on no longer putting them in the L1 fork of CMSSW). Would you be willing to wait just a bit for me to create a repository under our management that these could be inserted into instead? |
Hi Andrew, Sure, no problem -- just let me know what to do when it's ready. Also, wouldn't we still need to commit the change to the customiseSettings somewhere? How would that be handled? Molly |
Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X. |
At this point the calo params cleaning project has hit such a stall I don't fell right in leaving this PR hanging. I will sign this and add it into the cleanup project to be continued as we go. |
+l1 |
Please test |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d8a02/36911/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Add two L1T calo configs: v0_4_2 is currently used in the run, and lowers the jet seed threshold from 4 GeV to 2.5 GeV, and v0_4_3 we plan to switch to now, and has updated centrality thresholds for CENT6 and CENT7 for the UCC triggers.
PR validation:
These files represent L1 configuration to be stored centrally, and are not involved in any central workflows.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport. Will need to backport to CMSSW_13_2_X.