Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caloParams v0_4_2 and v0_4_3 #43046

Merged

Conversation

mitaylor
Copy link
Contributor

PR description:
Add two L1T calo configs: v0_4_2 is currently used in the run, and lowers the jet seed threshold from 4 GeV to 2.5 GeV, and v0_4_3 we plan to switch to now, and has updated centrality thresholds for CENT6 and CENT7 for the UCC triggers.

PR validation:
These files represent L1 configuration to be stored centrally, and are not involved in any central workflows.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport. Will need to backport to CMSSW_13_2_X.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43046/37239

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2023

A new Pull Request was created by @mitaylor (Molly Taylor) for master.

It involves the following packages:

  • L1Trigger/Configuration (l1)
  • L1Trigger/L1TCalorimeter (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

Hi @mitaylor, we've been asked to stop putting these into central CMSSW (even though I was the person who led the charge on no longer putting them in the L1 fork of CMSSW). Would you be willing to wait just a bit for me to create a repository under our management that these could be inserted into instead?

@mitaylor
Copy link
Contributor Author

Hi Andrew,

Sure, no problem -- just let me know what to do when it's ready. Also, wouldn't we still need to commit the change to the customiseSettings somewhere? How would that be handled?

Molly

@cmsbuild cmsbuild mentioned this pull request Oct 31, 2023
@smuzaffar
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

@smuzaffar smuzaffar modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023
@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_13_3_X Nov 6, 2023
@mitaylor
Copy link
Contributor Author

mitaylor commented Jan 5, 2024

@aloeliger
Copy link
Contributor

At this point the calo params cleaning project has hit such a stall I don't fell right in leaving this PR hanging. I will sign this and add it into the cleanup project to be continued as we go.

@aloeliger
Copy link
Contributor

+l1

@aloeliger
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d8a02/36911/summary.html
COMMIT: 663e50f
CMSSW: CMSSW_14_0_X_2024-01-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43046/36911/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e51992f into cms-sw:master Jan 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants