Removal of ZDC LUT file in caloParamsHelper and L1T workflow

[cfmcginn]

Removal of zdc LUT file query from L1TCaloStage2ParamsESProducer - obsolete

Also need to mod the caloParams file

PR description:

This PR removes ZDC LUT in CaloParamsHelper, made obsolete by recent PR:
#42818

• There should be no changes to output expected
• This should not depend on other PRs (PR above already removed any LUT use)
• Needed simply for L1 trigger development workflow

PR validation:

With PR, pre-existing L1Trigger development workflows no longer require presence of an unused and obsolete LUT

scram b runtests has some seemingly unrelated failures, but the most relevant test, L1Trigger/L1TGlobal/testL1TGlobalProducer, passes

Both of the below are applied
scram build code-checks
scram build code-format

Unclear if backport is necessary at this time; @bundocka can comment - given the small size of the PR, should be quick to prepare

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43502/38078

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TCalorimeter/python/caloParams_cfi.py modified in PR(s): Clean caloParams #43154

[cmsbuild]

A new Pull Request was created by @cfmcginn (Chris) for master.

It involves the following packages:

• L1Trigger/L1TCalorimeter (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43502/38346

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #43502 was updated. @cmsbuild, @aloeliger, @epalencia can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f8583/36803/summary.html
COMMIT: f725fe2
CMSSW: CMSSW_14_0_X_2024-01-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43502/36803/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 101 lines from the logs
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1386
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3245869
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1