Clean up HiFJRhoProducer

[fwyzard]

PR description:

Clean up HiFJRhoProducer:

• merge HiFJRhoProducer.h into HiFJRhoProducer.cc
• remove unnecessary methods and includes
• rename data members to follow the CMS coding conventions
• rearrange data members to reduce memory usage
• convert from "stream" to "global" EDProducer
• rewrite the for loop as a range loop
• remove one redundant temporary C array
• replace the other temporary C arrays with vectors

PR validation:

None.

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45570/41065

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• RecoHI/HiJetAlgos (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@dgulhan, @jazzitup, @kurtejung, @mandrenguyen, @missirol, @yenjie, @yetkinyilmaz, @yslai this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-389dba/40653/summary.html
COMMIT: 3af8ca4
CMSSW: CMSSW_14_1_X_2024-07-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45570/40653/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45570/41066

[cmsbuild]

Pull request #45570 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[fwyzard]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-389dba/40654/summary.html
COMMIT: 3ba8706
CMSSW: CMSSW_14_1_X_2024-07-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45570/40654/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3423932
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.