Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedxLikelihood to 2023 UPC rereco #46401

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Oct 16, 2024

PR description:

This PR adds the dEdx derived using the likelihood fit introduced in #45016 in the Run3 2023 UPC era for the 2024 re-reconstruction (using 14_1_X) of 2023 HIForward data.

@mandrenguyen

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)
  • RecoTracker/DeDx (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @GiacomoSguazzoni, @Ming-Yan, @Senphy, @VinInn, @VourMa, @ahinzmann, @andrzejnovak, @azotz, @castaned, @dgulhan, @felicepantaleo, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @mmusich, @mtosi, @nhanvtran, @rappoccio, @rovere, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test workflow 180,180.1,181,181.1,141.901,142.901,142.903

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7cc643/42229/summary.html
COMMIT: 679d6b3
CMSSW: CMSSW_14_2_X_2024-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46401/42229/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 16-Oct-2024 13:31:56 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIL2SingleMu0_Centrality40to100_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sSingleMu0Centrality40to100BptxAND'
Exception Message:

Algorithm L1_SingleMu0_Centrality_40_100_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_SingleMu0_Centrality_40_100_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 16-Oct-2024 13:34:00 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIL2SingleMu0_Centrality40to100_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sSingleMu0Centrality40to100BptxAND'
Exception Message:

Algorithm L1_SingleMu0_Centrality_40_100_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_SingleMu0_Centrality_40_100_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

@mmusich
Copy link
Contributor

mmusich commented Oct 16, 2024

please test workflow 180,180.1,181,181.1,141.901,142.901,142.903

you might want to test with #46398 until there's an IB with it.

@mmusich
Copy link
Contributor

mmusich commented Oct 17, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7cc643/42263/summary.html
COMMIT: 679d6b3
CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46401/42263/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

+1

@hqucms
Copy link
Contributor

hqucms commented Oct 17, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b7c40df into cms-sw:master Oct 18, 2024
11 checks passed
@stahlleiton stahlleiton deleted the Run3UPC_CMSSW_14_2_X branch October 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants