-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SiStripG2GainsValidator
#46414
Fix SiStripG2GainsValidator
#46414
Conversation
type bug-fix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46414/42268 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46414/42269 |
Pull request #46414 was updated. @atpathak, @consuegs, @francescobrivio, @perrotta can you please check and sign again. |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Thanks @perrotta. Do you mind opening an issue about it for future reference ? |
I already planned to do so, but I had to reach my office for it. |
+1 |
PR description:
This PR is a simple follow-up to #46382.
I noticed that the test started failing in
CMSSW_14_2_X_2024-10-16-1100
log, following up to a recent upload to the production SiStrip G2 tag (cmsTalk).The reasons lies in the fact that after that upload, we're currently in a situation in which the most recent IoV since (386968) in the production tag is more recent that the FCSR at the time of the test (386912). This leads calling the script
testCompareSiStripG2Gains.sh
with time-inverted arguments, which then causes crashes in the calls to thegetPayloadData.py
script.I fix this possible pitfall by changing the PCL FCSR to the HLT FCSR which is guaranteed to be >= to any possible upload to the production tag (barring upload mistakes).
I profit of this PR to remove a few unneeded import statements.
PR validation:
scram b runtests_test_SiStripG2GainsValidator
run as of Oct 16, 2024 22:30 runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A