Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SiStripG2GainsValidator #46414

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 16, 2024

PR description:

This PR is a simple follow-up to #46382.
I noticed that the test started failing in CMSSW_14_2_X_2024-10-16-1100 log, following up to a recent upload to the production SiStrip G2 tag (cmsTalk).
The reasons lies in the fact that after that upload, we're currently in a situation in which the most recent IoV since (386968) in the production tag is more recent that the FCSR at the time of the test (386912). This leads calling the script testCompareSiStripG2Gains.sh with time-inverted arguments, which then causes crashes in the calls to the getPayloadData.py script.
I fix this possible pitfall by changing the PCL FCSR to the HLT FCSR which is guaranteed to be >= to any possible upload to the production tag (barring upload mistakes).
I profit of this PR to remove a few unneeded import statements.

PR validation:

scram b runtests_test_SiStripG2GainsValidator run as of Oct 16, 2024 22:30 runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Oct 16, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CondCore/SiStripPlugins (db)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @VinInn, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 16, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46414 was updated. @atpathak, @consuegs, @francescobrivio, @perrotta can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8de8b9/42250/summary.html
COMMIT: 953ee39
CMSSW: CMSSW_14_2_X_2024-10-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46414/42250/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Oct 17, 2024

There are differences in Phase2 tests for HGCal DQM: they are clearly not originated by this PR, quite likely some non-reproducibility introduced with some of the latest merged PR

Thanks @perrotta. Do you mind opening an issue about it for future reference ?

@perrotta
Copy link
Contributor

There are differences in Phase2 tests for HGCal DQM: they are clearly not originated by this PR, quite likely some non-reproducibility introduced with some of the latest merged PR

Thanks @perrotta. Do you mind opening an issue about it for future reference ?

I already planned to do so, but I had to reach my office for it.
Here it is: #46416

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3b1948c into cms-sw:master Oct 17, 2024
11 checks passed
@mmusich mmusich deleted the fix_test_SiStripG2GainsValidator branch October 17, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants