-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrintTkMaps: Prefer to use data files from local area #46561
Conversation
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46561/42441 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: RelVals-INPUT
RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
@cms-sw/dqm-l2 , can you please review this. This change makes sure that unit tests picks up local data files |
ignore tests-rejected with ib-failure |
+dqm
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
#46456 added a unit tests which was picking up data files from cmssw release area only. This unit test will fail for full build IBs or PRs where we build full cmssw ( e.g https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5860f1/42470/unitTests/src/DQM/TrackerRemapper/test/testPrintTkMaps/testing.log ).
This PR fixes this issue by first looking for data files in local cmssw area and fallback to release if data file is missing in local area.
FYI @mmusich