Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrintTkMaps: Prefer to use data files from local area #46561

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

smuzaffar
Copy link
Contributor

#46456 added a unit tests which was picking up data files from cmssw release area only. This unit test will fail for full build IBs or PRs where we build full cmssw ( e.g https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5860f1/42470/unitTests/src/DQM/TrackerRemapper/test/testPrintTkMaps/testing.log ).

This PR fixes this issue by first looking for data files in local cmssw area and fallback to release if data file is missing in local area.

FYI @mmusich

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DQM/TrackerRemapper (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fioriNTU, @idebruyn, @jandrea, @mmusich, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-508c44/42488/summary.html
COMMIT: 4534239
CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46561/42488/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
  • 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
  • 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log
Expand to see more relval errors ...
  • 2024.101001
  • 2024.000001
  • 2024.001001
  • 2024.100001
  • 2024.101001

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569372
  • DQMHistoTests: Total failures: 429
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3568923
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@cms-sw/dqm-l2 , can you please review this. This change makes sure that unit tests picks up local data files

@smuzaffar
Copy link
Contributor Author

ignore tests-rejected with ib-failure

@antoniovagnerini
Copy link

antoniovagnerini commented Nov 4, 2024

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dbe04a9 into cms-sw:master Nov 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants