Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HLT online DQM client to cope with PbPb HLT strip collections #46622

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 7, 2024

PR description:

Title says it all, aimed to fix the empty Strip collections at HLT seen in the early 2024 PbPb runs, e.g. 387886 (link to DQM)

PR validation:

A full validation will need resolution of CMSHLT-3392 - thus draft for now. See #46622 (comment).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_14_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

cms-bot internal usage

@mmusich mmusich changed the title fix HLT client to cope with PbPb HLT strip collections fix HLT online DQM client to cope with PbPb HLT strip collections Nov 7, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)
  • DQM/Integration (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mtosi, @silviodonato, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2024

Pull request #46622 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 9, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2024

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa812a/42701/summary.html
COMMIT: 801ef51
CMSSW: CMSSW_14_2_X_2024-11-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46622/42701/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

@mmusich
Copy link
Contributor Author

mmusich commented Nov 11, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Nov 11, 2024

+hlt

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa812a/42731/summary.html
COMMIT: 801ef51
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46622/42731/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Nov 12, 2024

@cms-sw/dqm-l2 please review / sign.
We'll need to have the backport of this (#46667) for online operations.

@antoniovagnerini
Copy link

hi, 46622 was already deployed in production

@mmusich
Copy link
Contributor Author

mmusich commented Nov 12, 2024

hi, 46622 was already deployed in production

then, please sign :)

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 53ce4f3 into cms-sw:master Nov 13, 2024
11 checks passed
@mmusich mmusich deleted the mm_fix_hlt_client_HIon branch November 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants