-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix HLT online DQM client to cope with PbPb HLT strip collections #46622
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46622/42525 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
8290652
to
db85721
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46622/42555 |
Pull request #46622 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @rseidita can you please check and sign again. |
…ltSiPixelPhase1TrackResidualsAnalyzer
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46622/42557 |
-1 Failed Tests: RelVals RelVals
|
@cmsbuild, please test |
+hlt
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
@cms-sw/dqm-l2 please review / sign. |
hi, 46622 was already deployed in production |
then, please sign :) |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all, aimed to fix the empty Strip collections at HLT seen in the early 2024 PbPb runs, e.g. 387886 (link to DQM)
PR validation:
A full validation will need resolution of CMSHLT-3392 - thus draft for now.See #46622 (comment).If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to CMSSW_14_1_X