Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistancies with the Shotgun Sentry. #1764

Closed
NNJTM opened this issue Nov 29, 2022 · 4 comments
Closed

Inconsistancies with the Shotgun Sentry. #1764

NNJTM opened this issue Nov 29, 2022 · 4 comments
Assignees
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!

Comments

@NNJTM
Copy link

NNJTM commented Nov 29, 2022

Testmerges:

-#1546
-#1562
-#750
-#1760
-#1224

Description

Watching the Shotgun Sentry from a ghosted position revealed to me that pellet count is Inconsistent from what it should be.

Difference between expected and actual behavior

The Shotgun Sentry should shoot regular old Buckshot. 4 pellets, 65 damage each pellet. It seems inconsistent, hitting for less pellets even at point blank range.

Steps to reproduce

1.) Place shotgun sentry.
2.) Place enemy in range.
3.) Check logs and witness the inconsistent pellet count.

Issue bingo (not required to be all checked)

@Segrain Segrain added the Bug Admin events aren't bugs label Nov 29, 2022
@Segrain
Copy link
Contributor

Segrain commented Nov 29, 2022

Tested this on live server when it was reported. Sentry on thunderdome was shooting all the additional pellets as intended, but logs show sentries in the field proper only ever hitting with the main shell. Needs investigation.

@NNJTM
Copy link
Author

NNJTM commented Nov 29, 2022

Tested this on live server when it was reported. Sentry on thunderdome was shooting all the additional pellets as intended, but logs show sentries in the field proper only ever hitting with the main shell. Needs investigation.

To Clarify, this was on the map LV-642. In case that matters.

@Segrain Segrain self-assigned this Nov 30, 2022
@usnpeepoo
Copy link
Contributor

On a different note, shotgun sentries are kind of wacky. On a very laggy, high-pop round of LV I was playing runner and triggered the shotgun sentry but did not get immediately shot by it. Almost a minute later, I was carrying a capture and suddenly was hit by the triggered shotgun sentries pellets far away from it and went into crit instantly. I don't know if its a code related issue or a server side issue, but just wanted to say.

@Huffie56 Huffie56 added the Confirmed Bug We have the same at home! label Oct 13, 2023
@BOBAMAx BOBAMAx mentioned this issue Aug 26, 2024
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 28, 2024
# About the pull request

Fixes Issue #3053 (and potentially #1764)
This PR aims to fix a bug that has been around for a long time which is
explained below.
Changes tested.

The reason why buckshots and any other multi-projectile weapons (or
explosions) are not working correctly is because of the PR that added
random speed variance for projectiles (#1608). This PR caused the
buckshot's additional projectiles to either lag behind or go faster than
the main projectile which stuns the target, causing the additional
projectiles to not hit the target most of the time.
However there is also another factor which causes the additional
projectiles to not hit the target. That is the fact that when the main
projectile hits and stuns the target (makes them fall down to the
floor), the additional projectiles miss the target because they are on
the floor and go over the target.
This causes the shotgun to not deal the intended damage because only the
main projectile hits and barely does any damage.

**This is a bugfix. It doesnt buff the projectile damage in any way. It
technically also only affects stunnable targets because the problem is
targets being stunned and the projectiles missing them.
For example; Hivelords dont get stunned, therefore they dont have an
issue with the additional projectiles.**

# Explain why it's good for the game

A buckshot shouldn't miss a target that you are adjacent to.
The bug causes the buckshot to be completely useless at times, because
it doesnt work as intended.
Even though you are adjacent to your target, the projectiles miss the
target which clearly shouldn't happen.
If you are still confused as to what this PR fixes exactly, videos below
should show the problem.

# Testing Photographs and Procedure

**These are before / after footages. First video is before the fix,
second video is after the fix.**
<details>
<summary>Screenshots & Videos</summary>

Before


https://github.com/user-attachments/assets/364bb19e-25a5-4f6f-9dd3-ce4beea0fcfa

After


https://github.com/user-attachments/assets/b797c3b3-97d2-476b-bac6-f450b976efe6



</details>


# Changelog
:cl: Ansekishoku
fix: Buckshot additional projectiles no more miss the target when they
get stunned by the main projectile.
/:cl:

---------

Co-authored-by: Doubleumc <Doubleumc@users.noreply.github.com>
@Ansekishokuu
Copy link
Contributor

Fixed with #7406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!
Projects
None yet
Development

No branches or pull requests

6 participants