Buckshot Projectiles Not Hitting Targets Simultaneously #3053
Labels
Bug
Admin events aren't bugs
Confirmed Bug
We have the same at home!
Consistency Issue
Who needs consistency?
Comments
|
This is actually due to Fira´s SS projectile subsystem PR which adds a variation to bullet speed on all projectiles. |
|
#1764 potentially related |
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 28, 2024
# About the pull request Fixes Issue #3053 (and potentially #1764) This PR aims to fix a bug that has been around for a long time which is explained below. Changes tested. The reason why buckshots and any other multi-projectile weapons (or explosions) are not working correctly is because of the PR that added random speed variance for projectiles (#1608). This PR caused the buckshot's additional projectiles to either lag behind or go faster than the main projectile which stuns the target, causing the additional projectiles to not hit the target most of the time. However there is also another factor which causes the additional projectiles to not hit the target. That is the fact that when the main projectile hits and stuns the target (makes them fall down to the floor), the additional projectiles miss the target because they are on the floor and go over the target. This causes the shotgun to not deal the intended damage because only the main projectile hits and barely does any damage. **This is a bugfix. It doesnt buff the projectile damage in any way. It technically also only affects stunnable targets because the problem is targets being stunned and the projectiles missing them. For example; Hivelords dont get stunned, therefore they dont have an issue with the additional projectiles.** # Explain why it's good for the game A buckshot shouldn't miss a target that you are adjacent to. The bug causes the buckshot to be completely useless at times, because it doesnt work as intended. Even though you are adjacent to your target, the projectiles miss the target which clearly shouldn't happen. If you are still confused as to what this PR fixes exactly, videos below should show the problem. # Testing Photographs and Procedure **These are before / after footages. First video is before the fix, second video is after the fix.** <details> <summary>Screenshots & Videos</summary> Before https://github.com/user-attachments/assets/364bb19e-25a5-4f6f-9dd3-ce4beea0fcfa After https://github.com/user-attachments/assets/b797c3b3-97d2-476b-bac6-f450b976efe6 </details> # Changelog :cl: Ansekishoku fix: Buckshot additional projectiles no more miss the target when they get stunned by the main projectile. /:cl: --------- Co-authored-by: Doubleumc <Doubleumc@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 28, 2024
# About the pull request Fixes Issue #3053 (and potentially #1764) This PR aims to fix a bug that has been around for a long time which is explained below. Changes tested. The reason why buckshots and any other multi-projectile weapons (or explosions) are not working correctly is because of the PR that added random speed variance for projectiles (#1608). This PR caused the buckshot's additional projectiles to either lag behind or go faster than the main projectile which stuns the target, causing the additional projectiles to not hit the target most of the time. However there is also another factor which causes the additional projectiles to not hit the target. That is the fact that when the main projectile hits and stuns the target (makes them fall down to the floor), the additional projectiles miss the target because they are on the floor and go over the target. This causes the shotgun to not deal the intended damage because only the main projectile hits and barely does any damage. **This is a bugfix. It doesnt buff the projectile damage in any way. It technically also only affects stunnable targets because the problem is targets being stunned and the projectiles missing them. For example; Hivelords dont get stunned, therefore they dont have an issue with the additional projectiles.** # Explain why it's good for the game A buckshot shouldn't miss a target that you are adjacent to. The bug causes the buckshot to be completely useless at times, because it doesnt work as intended. Even though you are adjacent to your target, the projectiles miss the target which clearly shouldn't happen. If you are still confused as to what this PR fixes exactly, videos below should show the problem. # Testing Photographs and Procedure **These are before / after footages. First video is before the fix, second video is after the fix.** <details> <summary>Screenshots & Videos</summary> Before https://github.com/user-attachments/assets/364bb19e-25a5-4f6f-9dd3-ce4beea0fcfa After https://github.com/user-attachments/assets/b797c3b3-97d2-476b-bac6-f450b976efe6 </details> # Changelog :cl: Ansekishoku fix: Buckshot additional projectiles no more miss the target when they get stunned by the main projectile. /:cl: --------- Co-authored-by: Doubleumc <Doubleumc@users.noreply.github.com>
|
Should be fixed with #7406. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Testmerges
#2944 , #2964, #3031, #3039 , #3046 , #3040 , #3048 at time of report but this issue has existed for months.
Description of the bug
When firing a buckshot round from a shotgun, the round has two parts to it: the buckshot slug which causes the stun/slowdown/damage and the additional buckshot that just does basic damage but a lot of it. The issue is that when firing, the buckshot slug hits the target well before the additional buckshot. In most cases this does not matter because it all hits eventually. However, if a person shoots a warrior that has lunged a marine outside more than 1 tile away(not a point blank hit) the warrior is stunned by the slug, releases their target, and the additional buckshot then 'catches up' and hits the warrior's target due to the target instantly standing up.
What's the difference with what should have happened?
The projectiles should hit at the same instant. It makes zero sense that, if you shoot a warrior that has lunged a marine, you are going to hit the marine on the ground with your damage rather than the warrior. I asked in the coding section of the Discord if this was intended and every single person said it was absolutely not intended projectile behavior.
How do we reproduce this bug?
1.See marine lunged by a warrior.
2. Shoot warrior with a buckshot round while not PBing but also so that the slug portion of the round will stun said warrior.
3. Observe the warrior fall stunned while the marine that was lunged soaks all the damage.
4. Seethe.
Issue Bingo
The text was updated successfully, but these errors were encountered: