Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This one proudly demands that you REMEMBER IO! When it shouldn't #4916

Closed
3 tasks done
BadAtThisGame302 opened this issue Nov 13, 2023 · 3 comments · Fixed by #4930
Closed
3 tasks done

This one proudly demands that you REMEMBER IO! When it shouldn't #4916

BadAtThisGame302 opened this issue Nov 13, 2023 · 3 comments · Fixed by #4930
Labels
Bug Admin events aren't bugs

Comments

@BadAtThisGame302
Copy link
Contributor

Testmerges

#4475, #4812, #4793, #4866, #4915

Round ID

19508

Description of the bug

The Souto, Wey-Yu and alot of other posters should not begin with This one proudly demands that you REMEMBER IO! for obvious reasons

What's the difference with what should have happened?

The posters shouldn't have This one proudly demands that you REMEMBER IO! when they aren't about IO.

How do we reproduce this bug?

  1. Examine a poster
  2. See the description
  3. This one proudly demands that you REMEMBER IO!

Issue Bingo
@BadAtThisGame302 BadAtThisGame302 added the Bug Admin events aren't bugs label Nov 13, 2023
@Birdtalon
Copy link
Contributor

Unable to reproduce locally.
dreamseeker_2023-11-13_18-04-44

@BadAtThisGame302
Copy link
Contributor Author

image
image

@Birdtalon
Copy link
Contributor

Ok so it's the two posters in the CL office, map issue.

/obj/structure/sign/poster{
	desc = "A large piece of cheap printed paper. This one proudly demands that you REMEMBER IO!";
	icon_state = "poster14";
	name = "propaganda poster";
	pixel_y = 32
	},

@Birdtalon Birdtalon mentioned this issue Nov 14, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
@Birdtalon
Fixes propaganda posters in CL office (#4930)
03acf56 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->

# About the pull request

Fixes #4916 

It looks like someone wanted this to be the IO poster but didn't quite
get there.

# Explain why it's good for the game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding, and may discourage maintainers from reviewing or merging
your PR. This section is not strictly required for (non-controversial)
fix PRs or backend PRs. -->


# Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
label your changes in the changelog. Please note that maintainers freely
reserve the right to remove and add tags should they deem it
appropriate. You can attempt to finagle the system all you want, but
it's best to shoot for clear communication right off the bat. -->
<!-- If you add a name after the ':cl', that name will be used in the
changelog. You must add your CKEY after the CL if your GitHub name
doesn't match. Maintainers freely reserve the right to remove and add
tags should they deem it appropriate. -->

:cl:
fix: Fixes posters in CL office displaying IO description.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes propaganda posters in CL office Birdtalon/cmss13
2 participants
@Birdtalon @BadAtThisGame302