Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading resin walls to thick resin walls no longer allows nesting #5060

Closed
3 tasks done
Birdtalon opened this issue Nov 28, 2023 · 1 comment · Fixed by #5096
Closed
3 tasks done

Upgrading resin walls to thick resin walls no longer allows nesting #5060

Birdtalon opened this issue Nov 28, 2023 · 1 comment · Fixed by #5096
Labels
Bug Admin events aren't bugs

Comments

@Birdtalon
Copy link
Contributor

Testmerges

n/a

Round ID

No response

Description of the bug

When upgrading a resin wall to a thick resin wall the wall loses its ability to nest.

This is caused by upgrading the wall removes the hive weeds underneath so this return is hit.

var/turf/supplier_turf = get_turf(nest_structural_base)
var/obj/effect/alien/weeds/supplier_weeds = locate(/obj/effect/alien/weeds) in supplier_turf
if(!supplier_weeds)
to_chat(src, SPAN_XENOBOLDNOTICE("There are no weeds here! Nesting hosts requires hive weeds."))
return

What's the difference with what should have happened?

The wall should retain the ability to nest hosts.

How do we reproduce this bug?

  1. Make a normal resin wall on hive weeds
  2. Upgrade with hivelord to thick resin
  3. Try to nest a human

Issue Bingo

@Birdtalon Birdtalon added the Bug Admin events aren't bugs label Nov 28, 2023
@Birdtalon
Copy link
Contributor Author

Weeds are deleted here. Will look at this properly when I have a bit more time but want to get this documented.

if(istype(found_object, /obj/effect/alien/weeds))
qdel(found_object)

github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2023
# About the pull request

Fixes #5060

Side effect of this PR is that when resin walls are destroyed then do
not remove the weeds underneath. However those weeds should still be
linked to a nearby node and recede as normal when that is destroyed.

# Explain why it's good for the game


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Upgraded resin walls can now nest hosts.
/🆑
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant