Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwatch TGUI #1224

Closed
wants to merge 59 commits into from
Closed

Overwatch TGUI #1224

wants to merge 59 commits into from

Conversation

harryob
Copy link
Member

@harryob harryob commented Oct 10, 2022 •
edited
Loading

About The Pull Request

converts OW to using tgui from HTML

Why It's Good For The Game

soon the scourge that is HTML interfaces will be purged
CleanShot 2022-10-12 at 08 34 10@2x

Changelog

🆑 HarryOB
refactor: overwatch now uses TGUI
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Quality of Life Make the game harder to play labels Oct 10, 2022
stanalbatross
stanalbatross suggested changes Oct 10, 2022
View reviewed changes
code/modules/cm_marines/overwatch.dm Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
@stanalbatross stanalbatross added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Oct 10, 2022
@stanalbatross
Copy link
Contributor

squad monitor section does not expand when you pull down the UI 😢

@Googles-Hands Googles-Hands mentioned this pull request Nov 18, 2022
Closed
3 tasks
@sg2002
Copy link
Contributor

sg2002 commented Nov 19, 2022

Two problems I've noticed in a test round:

  1. When the DS gets locked, the OB says that it's not chambered. Probably need a separate message about the turret being locket.
  2. After the hijack if you try to look at squad monitor it crashes for some of the squads. Couldn't narrow it further yet.

@NNJTM NNJTM mentioned this pull request Nov 29, 2022
Closed
@harryob harryob marked this pull request as draft December 2, 2022 13:06
@Waseemq1235 Waseemq1235 mentioned this pull request Dec 2, 2022
Closed
3 tasks
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 10, 2022
@harryob harryob closed this Dec 11, 2022
@fira fira mentioned this pull request Dec 15, 2022
Merged
@harryob harryob deleted the overwatchtgui branch January 2, 2023 14:57
@harryob harryob restored the overwatchtgui branch January 2, 2023 14:57
@BeagleGaming1 BeagleGaming1 mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mullenpaul mullenpaul mullenpaul left review comments

@Segrain Segrain Segrain left review comments

@stanalbatross stanalbatross stanalbatross requested changes

@fira fira fira approved these changes

Assignees

@harryob harryob

Labels
Refactor Make the code harder to read Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players UI deletes nanoui/html
Projects
NanoUI/HTML to TGUI conversion
Status: PR merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@harryob @stanalbatross @morrowwolf @sg2002 @fira @Segrain @mullenpaul