-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xeno Backpacks #1274
Xeno Backpacks #1274
Conversation
Fix no sfx for emptying a storage
Gibbing a xeno currently destroys any equipped bag. Should this behavior not be desired /mob/living/carbon/gib in carbon.dm can have a check to drop the bag. I'm inclined to leave it this way because usually any situation that is gibbing them should be enough reason to destroy any bag too, but at the same time xeno bodies gib rather frequently too. |
PR is suitable for merging (don't feel discouraged to test and review), but will be drafted while Jean still has more sprites in progress. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
…ks), spitter regular/medical, sentinel regular/medical, drone regular/medical, defender regular/medical (needs tweaks).
Unfortunately we want a base class to be allowed so we have to override that.
…ng it once they have their first backpack) Refactor atom/moveable/vis_obj to be more generic
…ere is already a flag to inherit direction?
Update crit sprites for warrior
…support the icons).
Fix xeno wounds inheriting hive color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code checks out, still needs sprite approval
# Conflicts: # code/modules/mob/living/carbon/xenomorph/update_icons.dm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprites will work, APPROVED.
About The Pull Request
This pull request adds support for marines to strap a backpack onto allied xenos. The xeno cannot view the contents of the bag nor interact with it any way other than through a new shake verb. Marines also have access to the new shake verb for any emptyable storage item. Shaking a storage item that is either in your hands or back slot has a high chance to drop out a single item. Xenos that shake an empty backpack also have a low chance to drop the backpack on the ground.
Strapping on, unstrapping, and accessing any allied xeno backpack does take some time to complete.
The item class size of gardener and healer fruit has been lowered to medium, but they occupy more space in a bag than a regular medium item (so only five can fit in a typical bag). The intention of this change is to allow a bag loaded with either fruit (for xenos) or medical supplies (for marines) that a xeno can go out and distribute, but its primarily on a marine to facilitate this.
Sprites were created by Jean 'Docteur' Corbeau aka SubjectD9341.
NOTE: Some sprites in above are no longer accurate. See updated images below...
Sprite progress (though ultimately up to them how far they want to go):
Any unlisted castes aren't planned at this time.
Why It's Good For The Game
Opens up more interactions between marines and xenos, namely for friendly "greenos". Encourages more cooperation between a friendly xeno faction because equipping and loading of these backpacks can only be performed by a marine; a xeno can only shake items out or shake the bag off. Allowing fruit to be placed in bags is primarily to allow a medic roony to either provide healing to xenos by shaking out some fruit, or to marines by shaking out some medical supplies.
Changelog
🆑 Drathek, SubjectD9341
add: Standard issue marine backpacks can now be equipped to most allied xenos (Runners/Praetorians/Drones/Defenders/Warriors/Sentinels/Spitters) and accessed. Use a pack in help intent on a xeno to strap it to her after a duration. Access it with an empty hand in help intent after a duration. Drag a xeno with a pack to you when you have an empty hand to unstrap it from her after a duration.
add: Added the Shake verb to storage items. Humans and xenos can now shake emptyable inventories which has a 75% chance to drop an item if there are any. Xenos also have a 25% chance to cause the pack fall off them when empty.
balance: Resin fruit is now class size medium but size cost large so five can fit in a backpack.
soundadd: Emptying a storage item now uses the existing rustle sound (or whatever use_sound its configured to use).
soundadd: Unequipping a backpack now uses the existing rustle sound (or whatever use_sound its configured to use).
imageadd: Added sprites for regular and medical packs on Runners/Praetorians/Drones/Defenders/Warriors/Sentinels/Spitters.
code: Any storage item that is STORAGE_ALLOW_EMPTY now either adds/removes empty_verb and toggle_click_empty depending on if the user is a xeno.
code: Refactored /atom/movable/vis_obj/xeno_wounds so it can be more generic as just vis_obj (now it will be used by both wounds and packs and packs don't need to be xeno_wounds) and use VIS_INHERIT_DIR instead of a signal.
fix: Xeno wounds no longer inherit hive color.
/:cl: