Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the M4A3, M44 Custom to loadout. Makes them cosmetic only removes them from everywhere else (With Nanu's permission) #1457

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

spartanbobby
Copy link
Contributor

@spartanbobby spartanbobby commented Nov 6, 2022

About The Pull Request

This PR removes both customs from loadouts/vendors across the USS Almayer, replacing them with either the inlore standard issue 88 mod, back issue M4A3 or regular M44 revolver. The stats of both of these weapons were flattened to be the same as their regular counterparts and were added to custom loadout for 4 points (M4A3 Custom) and 7 points (M44 Custom)

Why It's Good For The Game

https://www.youtube.com/watch?v=aHjRQJZsUGg (Vazques's custom visible)
https://i.imgur.com/uqcBF7D.jpeg (better picture)

In some ways I think the M4A3 custom has snowballed, going from a CO-only weapon back on the Sulaco to a SO weapon and now if you read my changes you'll see a lot of roles have access to what is just an M4A3 with a damage mult weapons that boil down to X but statistically, better I feel are somewhat bad for the game. While I was talking to Nanu about these changes he requested I do the same for the M44 Custom revolver as well

The M4A3 Custom is based on PFC Vazques's custom pistol seen in the second movie the assumption we're making here is that the same Gunsmith could've sold the same 'type' of work to other marines to keep with the M44 being much rarer it costs more at a hefty 7 points

Changelog

🆑 SpartanBobby
add: M4A3 Custom added to custom loadout for 4 points
add: M44 Custom added to custom loadout for 7 points
del: Removed M4A3 and M44 Custom from areas not custom loadout, replaced with regular counterparts or 88 Mod 4 Combat Pistol
balance: M4A3 and M44 Custom pistols now share the same stats as their regular counterparts
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Nov 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

You currently have a negative Fix/Feature pull request delta of -23. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Feature Feature coder badge Removal snap Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Nov 6, 2022
@Nanu308 Nanu308 added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Mapping Approved adds 500 new dict keys labels Nov 8, 2022
@Geevies Geevies marked this pull request as draft November 13, 2022 15:56
@spartanbobby spartanbobby marked this pull request as ready for review November 16, 2022 12:07
@Geevies Geevies merged commit 770a355 into cmss13-devs:master Nov 16, 2022
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-34). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request Nov 16, 2022
@Googles-Hands Googles-Hands mentioned this pull request Nov 18, 2022
3 tasks
@spartanbobby spartanbobby deleted the Customs branch November 19, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Removal snap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants