Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes preds not having their bones broken, rebalances it as well. #2984

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

DecemberIsHere
Copy link
Contributor

About the pull request

Preds have had their bones unbreakable since march of 2021, due to a change in limbs.dm code regarding bonebreak invulnerability chances during tech webs. This PR fixes the longstanding bug, but also rebalances it due to the major concerns of extremely easy bone breaks which were a common thing in the past.

Explain why it's good for the game

Bug, similar to preds hard crit bug. This does not necessarily gimp pred fights versus humans, and its likely that a pred would be slowed due to pain/blood loss within the damage necessary to accrue a bone break. Preds also have bones, and although they're a stronger species are not immune to bone breaks. Medicomp currently fixes bone breaks, and thwei allows for autoheal within a set amount of time. Overall, nothing will really change aside from preds being able to break their bones again.

Testing Photographs and Procedure

Tested on a private server with multiple ammo types/common marine loadouts along with xenos. Works as intended.

Changelog

🆑 Usnpeepoo
fix: Preds are able to break their bones again
balance: Pred bones have their minimum damage to break requirements balanced.
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -5. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Fix Fix one bug, make ten more Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Mar 31, 2023
Co-authored-by: BeagleGaming1 <56142455+BeagleGaming1@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 8, 2023
@harryob harryob removed the Stale beg a maintainer to review your PR label Apr 13, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code fine needs bälance

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 21, 2023
@K4rlox K4rlox mentioned this pull request Apr 23, 2023
3 tasks
@morrowwolf morrowwolf removed the Stale beg a maintainer to review your PR label Apr 24, 2023
@morrowwolf
Copy link
Member

TM'd not stale.

@morrowwolf morrowwolf added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 26, 2023
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do fine. Complaints minimal. Council happy. All systems nominal.

@morrowwolf morrowwolf added this pull request to the merge queue Apr 26, 2023
Merged via the queue into cmss13-devs:master with commit 2057ada Apr 26, 2023
cm13-github added a commit that referenced this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants