-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes preds not having their bones broken, rebalances it as well. #2984
Fixes preds not having their bones broken, rebalances it as well. #2984
Conversation
You currently have a negative Fix/Feature pull request delta of -5. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
Co-authored-by: BeagleGaming1 <56142455+BeagleGaming1@users.noreply.github.com>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code fine needs bälance
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
TM'd not stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to do fine. Complaints minimal. Council happy. All systems nominal.
About the pull request
Preds have had their bones unbreakable since march of 2021, due to a change in limbs.dm code regarding bonebreak invulnerability chances during tech webs. This PR fixes the longstanding bug, but also rebalances it due to the major concerns of extremely easy bone breaks which were a common thing in the past.
Explain why it's good for the game
Bug, similar to preds hard crit bug. This does not necessarily gimp pred fights versus humans, and its likely that a pred would be slowed due to pain/blood loss within the damage necessary to accrue a bone break. Preds also have bones, and although they're a stronger species are not immune to bone breaks. Medicomp currently fixes bone breaks, and thwei allows for autoheal within a set amount of time. Overall, nothing will really change aside from preds being able to break their bones again.
Testing Photographs and Procedure
Tested on a private server with multiple ammo types/common marine loadouts along with xenos. Works as intended.
Changelog
🆑 Usnpeepoo
fix: Preds are able to break their bones again
balance: Pred bones have their minimum damage to break requirements balanced.
/:cl: