Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROADMAP] tightens communications #3060

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Conversation

ItsVyzo
Copy link
Contributor

@ItsVyzo ItsVyzo commented Apr 13, 2023

About the pull request

Tightens communications as per roadmap https://github.com/orgs/cmss13-devs/projects/6/views/1?pane=issue&itemId=23382941

Explain why it's good for the game

Balance

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 LTNTS
balance: Limited communications for PO/DCC/CT/MST/CL/VC
fix: IO/VC now use their own encryption keys
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Apr 13, 2023
@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -4. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@morrowwolf
Copy link
Member

Otherwise, I'd like to see how this effects things. I'm not sold one way or the other but let's see how it goes.

@morrowwolf morrowwolf marked this pull request as draft April 17, 2023 18:59
@ghost

This comment was marked as off-topic.

@ItsVyzo ItsVyzo marked this pull request as ready for review April 18, 2023 03:02
@ItsVyzo ItsVyzo requested a review from morrowwolf April 18, 2023 03:02
@ItsVyzo
Copy link
Contributor Author

ItsVyzo commented Apr 18, 2023

Otherwise, I'd like to see how this effects things. I'm not sold one way or the other but let's see how it goes.

It will be an interesting change, however I think depending on how limited communication is it could either be good or bad. Also, with the new RTO changes, it might push people to use radiopacks more. Good portion of this really depends on marine competence.

@morrowwolf morrowwolf added the Fix Fix one bug, make ten more label Apr 21, 2023
@morrowwolf morrowwolf added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 21, 2023
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This along with radio backpacks being more distributed should allow for communications to be a bit tighter without issue.

@morrowwolf morrowwolf added the Roadmap "I think you're holding it upside down" label Apr 21, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Apr 21, 2023
Merged via the queue into cmss13-devs:master with commit 928feda Apr 21, 2023
cm13-github added a commit that referenced this pull request Apr 21, 2023
@ItsVyzo ItsVyzo deleted the tighter_comms branch April 21, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Roadmap "I think you're holding it upside down"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants