-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Game Mode Start Handling #5506
Tweak Game Mode Start Handling #5506
Conversation
Ticker will automatically try again once, otherwise it alerts admins or if there's no admins, changes to default game mode and initiates map vote
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Whisky Outpost is so rare now that it has taken two months for anyone to notice that it has been throwing a runtime when determining how many players are required for the game mode (140). Additionally, the Ticker subsystem really poorly handled this situation.
This PR makes it so:
Explain why it's good for the game
This should hopefully be less confusing to people what's going on when a game mode like WO fails to start and give admins an easier time to handle situations like this.
Testing Photographs and Procedure
Screenshots & Videos
No Admins (or afk admins):With Admins:
Changelog
🆑 Drathek
add: The game will now change game mode to default and initiate a map vote if a game mode fails to start twice and there are no admins online.
fix: Fixed a runtime during game mode voting
admin: Admins can now use the Start Round verb to bypass a gamemode's checks
/:cl: