Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Game Mode Start Handling #5506

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jan 20, 2024

About the pull request

Whisky Outpost is so rare now that it has taken two months for anyone to notice that it has been throwing a runtime when determining how many players are required for the game mode (140). Additionally, the Ticker subsystem really poorly handled this situation.

This PR makes it so:

  • Admins can bypass checks to start a game mode
  • Messages when a game mode fails to start is more verbose
  • A game mode that fails to start will attempt again once
  • Otherwise it will set game mode to default and initiate a game map vote and restart if there are no active admins; or it will delay start and message admins.

Explain why it's good for the game

This should hopefully be less confusing to people what's going on when a game mode like WO fails to start and give admins an easier time to handle situations like this.

Testing Photographs and Procedure

Screenshots & Videos No Admins (or afk admins):

no_admins

With Admins:

admins

Changelog

🆑 Drathek
add: The game will now change game mode to default and initiate a map vote if a game mode fails to start twice and there are no admins online.
fix: Fixed a runtime during game mode voting
admin: Admins can now use the Start Round verb to bypass a gamemode's checks
/:cl:

Ticker will automatically try again once, otherwise it alerts admins or if there's no admins, changes to default game mode and initiates map vote
@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more Admin Make things harder for admins labels Jan 20, 2024
@Drulikar Drulikar mentioned this pull request Jan 20, 2024
3 tasks
@MemesLauncher MemesLauncher mentioned this pull request Jan 26, 2024
3 tasks
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 28, 2024
@Birdtalon Birdtalon added this pull request to the merge queue Jan 28, 2024
Merged via the queue into cmss13-devs:master with commit 20db241 Jan 28, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 28, 2024
@cuberound cuberound mentioned this pull request Jan 29, 2024
3 tasks
@Drulikar Drulikar deleted the Tweak_Gamemode_Handling branch January 29, 2024 11:43
@cuberound cuberound mentioned this pull request Jan 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Feature Feature coder badge Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants