Egg orphans and fragile egg fixes #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
Testmerge Candidate
cmss13-ci
bot
added
Balance
cm13-github
added a commit
that referenced
this pull request
Nov 10, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 11, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 11, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 11, 2024
3 tasks
harryob
approved these changes
Nov 12, 2024
|
This is only a semi fix for #7405, as they can still expand weeds on tiles they shouldn't normally be able to. |
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
# About the pull request This PR is a follow up to #7554 bumping the timer from 6 mins (from 5 mins) since the hive core reconstruction time (`HIVECORE_COOLDOWN`) is 5 mins (to allow 1 minute window to restore a hive w/o all eggs popping). # Explain why it's good for the game Should xenos manage to hold their original hive location to rebuild a hive core, this should make it possible to recover most eggs planted there. # Changelog :cl: Drathek balance: Increased orphan egg time from 5 mins to 6 mins. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes a couple bugs with xeno eggs and also adds a mechanic where eggs that have lost their weeds will become fragile. These eggs use the
CARRIER_EGG_MAXIMUM_LIFEvalue (5 mins) but will convert back to normal eggs if their hive weeds are restored. If this doesn't discourage the weird behavior of placing and destroying pylons, we can just entirely remove the logic that restores the eggs to normal eggs.For fixes, there was a check on egg/click that prevented egg interaction if you weren't close or are a ghost, but it needed to first call parent first for examine logic. Then there was an issue where the timer for egg carrier eggs would get deleted if called the Burst proc (but it failed to check if the burst was from just someone retrieving the hugger)
Forsaken variants of the new eggs will last indefinitely.
Explain why it's good for the game
Right now its possible to make eggs even on semi-weedable surfaces. This PR still allows this but they will only last 5 minutes if they don't have their weeds restored in time. In general I am okay with xenos creating traps for marines to get hugged, but doing so through weird mechanics like cycling a pylon construction needs to be discouraged.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/Hbyk6OikyjU
Changelog
🆑 Drathek
balance: Eggs that lose their hive weeds will now turn fragile (like egg carrier eggs) lasting 5 minutes.
fix: Fixed an exploit allowing egg carrier eggs to last indefinitely.
fix: Fixed the inability to examine planted eggs from further than one tile.
/:cl: