-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stack backtrace #548
Conversation
Signed-off-by: clundro <clusternlh@gmail.com>
Wow, this is really useful! Thanks a lot! |
This comment was marked as spam.
This comment was marked as spam.
Signed-off-by: clundro <clusternlh@gmail.com>
for example, current assert behavior:
expected assert behavior:
|
This comment was marked as spam.
This comment was marked as spam.
acda172
to
78dbded
Compare
Signed-off-by: clundro <clusternlh@gmail.com>
78dbded
to
3fafcd9
Compare
after trying this on private repo, it seems that we cannot de-mangle symbols on macOS. Probably I'll prefer wait for another compiler version bump and use https://en.cppreference.com/w/cpp/utility/basic_stacktrace instead in C++ 23. |
ok, maybe this situation is related to NationalSecurityAgency/ghidra#4652. so shall i close the pr or change it to use basic_stacktrace? |
Let’s keep it and I’ll probably see if there’s any chance to integrate it. |
issue : #309
just move the stack trace impl in muduo to bustub.