Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Sep 20, 2021

closes #1008 based on #1012

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

before:

image

after:

image

notes
the build fails since there are some changed in the Google doc before this PR that haven't been incorporated.

@sgratzl sgratzl self-assigned this Sep 20, 2021
@sgratzl sgratzl added the bug Something isn't working label Sep 20, 2021
@sgratzl sgratzl requested a review from krivard September 20, 2021 16:49
@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Preview link ready!

🔨 Explore the source changes: 010e698

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/614a00f4ecec9c0008e8c458

😎 Browse the preview: https://deploy-preview-1013--cmu-delphi-covidcast.netlify.app

@krivard
Copy link
Contributor

krivard commented Sep 21, 2021

Ah, we do want % for changes though. "Better by -0.20" --> "Better by -20%", since otherwise it sounds like we're saying 5.2 = 6.3 - 0.20

image

& same in the"Increasing" chip and the "Change last 7 days" columns

@sgratzl
Copy link
Member Author

sgratzl commented Sep 21, 2021

Ah, we do want % for changes though. "Better by -0.20" --> "Better by -20%", since otherwise it sounds like we're saying 5.2 = 6.3 - 0.20

fixed

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit f0af3fd into dev Sep 22, 2021
@sgratzl sgratzl deleted the sgratzl/double_unit branch September 22, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Percentages are double-labeled with both % and "per 100"

3 participants