Config Mixin #398
Closed
Config Mixin #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… separating it from the HTML. Added error-handling if the config is not found. Updated handleError to account for config not found.
|
@gobsmack Update: we are reviewing this. |
|
I've added this config mixin to a new branch with additional Controller mixins for further discussion. |
|
This will be coming. Closing PR as we will incorporate this via another branch. |
|
this mixin for the config file was included in PR #475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to move the config loading logic into a Mixin. This should make it easier to override the default behaviour of loading the config from a single file. By providing a custom mixin, one can easily load a config from a database, from a different URL, or by some other method. And, this can be done without modifying the core CMV code.
This does not address when a separate widget config filename is embedded in the config file itself. That will still perform a simple "require" for the widgetConfig.options.