Migrate from jshint to eslint #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified JS files so they pass extensive eslint tests
updated package.json and Gruntfile.js for hinting locally
using `grunt hint` and on build with travis-ci for each commit.
The travis run should fail if there are eslint errors.
using new container-based infrastructure.
eslint-stylish is now included with eslint so should not be required.
will fail when elint fails.
travis build failed as expected with errors listed in build job log.
|
@tmcgee This has issues and is unmergeable. |
|
Hmmm. There were no conflicts when submitted. It most likely the 2 files with proj4 changes that were just merged. I will review later tonight. |
|
Just a heads up :) |
Conflicts: viewer/js/gis/dijit/StreetView.js
|
@btfou: good to go now. |
|
Good work. Looking forward to pulling this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.