Added new layerIds option to layerControl configuration.
#477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This array determines which sublayer and folder controls are visible. The visibility of the actual sublayers is not affected. Also includes `layerIds` array in imageParameters to demonstrate how to set the initial visibility of sublayers.
| @@ -35,6 +35,10 @@ define([ | |||
| _expandClickHandler: null, | |||
| postCreate: function () { | |||
| this.inherited(arguments); | |||
| // Should the control be visible or hidden? | |||
| if (this.control.controlOptions.layerIds && this.control.controlOptions.layerIds.indexOf(this.sublayerInfo.id) < 0) { | |||
There was a problem hiding this comment.
There is a potential issue here with array.indexOf(). It is only supported in IE 9+ this breaks in IE 8 and below. I will approve for now but lets look at using dojo/array.indexOf() that will abstract this issue.
There was a problem hiding this comment.
@DavidSpriggs you are correct and I will add the fix. I believe I saw indexOf used this way in some other widget. I'll track down that instance as well.
DavidSpriggs
added a commit
that referenced
this pull request
Nov 23, 2015
…and-folders Added new `layerIds` option to layerControl configuration.
DavidSpriggs
deleted the
feature/layerControl-hide-sublayers-and-folders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This array determines which sublayer and folder controls are visible.
The visibility of the actual sublayers is not affected.
Also includes
layerIdsarray in imageParameters to demonstrate how toset the initial visibility of sublayers.