Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change topic 'LayerControl' to 'layerControl' #503

Merged
merged 2 commits into from
Feb 3, 2016
Merged

Change topic 'LayerControl' to 'layerControl' #503

merged 2 commits into from
Feb 3, 2016

Conversation

green3g
Copy link
Member

@green3g green3g commented Jan 28, 2016

Breaking Change:

  • Change the topic published by the layerControl from LayerControl/menuItemTopic to layerControl/menuItemTopic for consistency.

@tmcgee
Copy link
Member

tmcgee commented Jan 29, 2016

@roemhildtg I think this commit will conflict with PR #500 once it is merged (or vice-versa). I am waiting to see if @btfou has any thoughts additions about those changes. I will fearlessly :) merge that PR if he doesn't have input in the near future.

@green3g
Copy link
Member Author

green3g commented Jan 29, 2016

Ah yes, you're probably right. I'll resubmit after its merged.

@DavidSpriggs
Copy link
Member

@roemhildtg Merge and repost.

tmcgee added a commit that referenced this pull request Feb 3, 2016
…sistency

Change topic 'LayerControl' to 'layerControl'
@tmcgee tmcgee merged commit 7607d82 into cmv:develop Feb 3, 2016
@green3g green3g deleted the fix/layer-control-topic-inconsistency branch April 19, 2016 17:17
@tmcgee tmcgee mentioned this pull request Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants