Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entity escaping in rss.xml #46

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

woefe
Copy link
Contributor

@woefe woefe commented Apr 18, 2024

Fixes the entity escaping in the RSS item description. Uses the same escaping mechanism as the default Hugo rss template.

transform.XMLEscape requires Hugo 0.121.0 or newer. https://gohugo.io/functions/transform/xmlescape/

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for dot-org-hugo-theme-demo-thetwopct failed.

Name Link
🔨 Latest commit 8442de9
🔍 Latest deploy log https://app.netlify.com/sites/dot-org-hugo-theme-demo-thetwopct/deploys/6620d076b9a82c00083802e9

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for dot-org-hugo-theme-demo failed. Why did it fail? →

Name Link
🔨 Latest commit 8442de9
🔍 Latest deploy log https://app.netlify.com/sites/dot-org-hugo-theme-demo/deploys/6620d076b9a82c00083802ee

Signed-off-by: Wolfgang Popp <mail@wolfgang-popp.de>
@woefe
Copy link
Contributor Author

woefe commented Apr 18, 2024

What's your policy on the Hugo version? I see the netlify bot is currently building with 0.115.4.

An alternative fix could be to use | html as in older versions of the default hugo template: gohugoio/hugo@b4c5df4#diff-76032d349eedf06717453a1b01a0ebab2b4324b19533b2825f18eb9a2a377e6b

@chalin
Copy link

chalin commented May 14, 2024

@cjyabraham - just curious, why you're not using the Hugo RSS template?

@cjyabraham
Copy link
Contributor

@cjyabraham - just curious, why you're not using the Hugo RSS template?

@thetwopct, any thoughts?

@thetwopct
Copy link
Collaborator

@cjyabraham - just curious, why you're not using the Hugo RSS template?

Tbh, I can't remember now, but pretty sure it wasn't showing the content I wanted it too. I can try switching back if I get time. Also @woefe thanks for your PR, and sorry for not approving it yet, I haven't had a chance to work on this theme recently.

@thetwopct thetwopct changed the base branch from main to version-0.1.5 May 21, 2024 08:00
Copy link
Collaborator

@thetwopct thetwopct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, will be released in v0.1.5 of the theme

@thetwopct thetwopct merged commit dd70ac6 into cncf:version-0.1.5 May 21, 2024
1 check passed
@thetwopct thetwopct mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants