Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility errors #468

Closed
dankohn opened this issue Nov 23, 2019 · 2 comments
Closed

Fix accessibility errors #468

dankohn opened this issue Nov 23, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dankohn
Copy link
Contributor

dankohn commented Nov 23, 2019

https://tourmaline-salsa.glitch.me/
https://webhint.io/scanner/e5e3ec29-d41a-4bbb-92e0-189d3c70986b

Most of them can be fixed with alt tags and starker contrast.

@jordinl
Copy link
Contributor

jordinl commented Dec 4, 2019

There are two more additional issues on the modal page: https://webhint.io/scanner/3a54bce0-1320-4bb3-b7ee-a4d85faddd42

The ARIA roles used must conform to valid values error happens because the modal (from Material UI) has role="none presentation". Webhint is giving an error because multiple roles is not well supported dequelabs/axe-core#1916. On the other hand multiple roles are actually allowed: https://www.w3.org/TR/2014/REC-wai-aria-implementation-20140320/#mapping_role

WAI-ARIA allows multiple roles to be specified as an ordered set of space-separated valid role tokens. The additional roles are fallback roles similar to the concept of specifying multiple fonts in case the first choice font type is not supported.

The ARIA hidden element must not contain focusable elements happens because Material UI adds aria-hidden=true to elements outside the modal, but one of the divs with aria-hidden=true contains an element with tabindex=0 which causes this error. There's an issue opened with axe-core discussing if this is a false positive: dequelabs/axe-core#1482

I think there's nothing we can do to fix these right now.

@jordinl
Copy link
Contributor

jordinl commented Dec 10, 2019

Closing with #484

@jordinl jordinl closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants