Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bazel to 4.2.2 #68

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Bump bazel to 4.2.2 #68

merged 1 commit into from
Oct 16, 2023

Conversation

sergiitk
Copy link
Contributor

@sergiitk sergiitk commented Oct 6, 2023

This fixes the (Segmentation fault): protoc failed issue when building on Mac: protocolbuffers/protobuf#9172.

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
@sergiitk sergiitk marked this pull request as draft October 6, 2023 08:51
@sergiitk sergiitk marked this pull request as ready for review October 12, 2023 20:46
@sergiitk
Copy link
Contributor Author

sergiitk commented Oct 12, 2023

@kyessenov - ready for review.

Copy link

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit 8bd2eac into cncf:main Oct 16, 2023
2 checks passed
@sergiitk sergiitk deleted the bump-bazel-422 branch October 16, 2023 23:01
sergiitk added a commit to sergiitk/envoy that referenced this pull request Nov 10, 2023
cncf/xds@e9ce688...523115e

- cel: add a description to the AST (cncf/xds#61)
- Bump bazel to 4.2.2 (cncf/xds#68)
- bazel: fix "missing strict dependencies" build issue (cncf/xds#72)
  - bazel version updated from `4.2.2` to `6.3.2`
  - `protoc-gen-validate` dependencies updated to match Envoy's

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
mattklein123 pushed a commit to envoyproxy/envoy that referenced this pull request Nov 13, 2023
cncf/xds@e9ce688...523115e

- cel: add a description to the AST (cncf/xds#61)
- Bump bazel to 4.2.2 (cncf/xds#68)
- bazel: fix "missing strict dependencies" build issue (cncf/xds#72)
  - bazel version updated from `4.2.2` to `6.3.2`
  - `protoc-gen-validate` dependencies updated to match Envoy's

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
update-envoy bot added a commit to envoyproxy/data-plane-api that referenced this pull request Nov 13, 2023
cncf/xds@e9ce688...523115e

- cel: add a description to the AST (cncf/xds#61)
- Bump bazel to 4.2.2 (cncf/xds#68)
- bazel: fix "missing strict dependencies" build issue (cncf/xds#72)
  - bazel version updated from `4.2.2` to `6.3.2`
  - `protoc-gen-validate` dependencies updated to match Envoy's

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

Mirrored from https://github.com/envoyproxy/envoy @ b500165160ce60020ad55bf6b10c6d5cc0b5f54c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants