bazel: fix "missing strict dependencies" build issue #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
force-pushed
the
bazel-build-fix
branch
2 times, most recently
from
4b8e039 to
b50be00
Compare
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Before: protoc-gen-go v1.25.0 After: protoc-gen-go v1.28.1 Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
sergiitk
force-pushed
the
bazel-build-fix
branch
from
16bd2ab to
f094e7e
Compare
|
@adisuissa - please review - this unblocks all builds in this repo. |
Closed
Closed
sergiitk
added a commit
to sergiitk/envoy
that referenced
this pull request
Nov 10, 2023
cncf/xds@e9ce688...523115e - cel: add a description to the AST (cncf/xds#61) - Bump bazel to 4.2.2 (cncf/xds#68) - bazel: fix "missing strict dependencies" build issue (cncf/xds#72) - bazel version updated from `4.2.2` to `6.3.2` - `protoc-gen-validate` dependencies updated to match Envoy's Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
mattklein123
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 13, 2023
cncf/xds@e9ce688...523115e - cel: add a description to the AST (cncf/xds#61) - Bump bazel to 4.2.2 (cncf/xds#68) - bazel: fix "missing strict dependencies" build issue (cncf/xds#72) - bazel version updated from `4.2.2` to `6.3.2` - `protoc-gen-validate` dependencies updated to match Envoy's Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
update-envoy bot
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Nov 13, 2023
cncf/xds@e9ce688...523115e - cel: add a description to the AST (cncf/xds#61) - Bump bazel to 4.2.2 (cncf/xds#68) - bazel: fix "missing strict dependencies" build issue (cncf/xds#72) - bazel version updated from `4.2.2` to `6.3.2` - `protoc-gen-validate` dependencies updated to match Envoy's Signed-off-by: Sergii Tkachenko <sergiitk@google.com> Mirrored from https://github.com/envoyproxy/envoy @ b500165160ce60020ad55bf6b10c6d5cc0b5f54c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the build issue, likely caused by unpinned transitive dependencies of
protoc-gen-validate:The problem is solved by matching
protoc-gen-validatewith the version used by Envoy:4.2.2to6.3.2(updated bazel-gazelle fails with 4.2.2)github.com/bazelbuild/bazel-gazelleupdated fromv0.23.0tov0.31.1github.com/bazelbuild/rules_goupdated fromv0.27.0tov0.39.11.16.6to1.20.2com_github_lyft_protoc_gen_starupgraded fromv0.5.1tov2.0.1golang.org/x/netpinned tov0.0.0-20200226121028-0de0cce0169bgolang.org/x/textpinned tov0.3.3google.golang.org/protobufpinned tov1.28.1