From 091420ae2677ecedd1a26a238921321c2a191675 Mon Sep 17 00:00:00 2001 From: fengmk2 Date: Thu, 1 Sep 2022 23:26:15 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20TEST:=20Add=20SQL=20Review=20Act?= =?UTF-8?q?ion=20(#307)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://github.com/marketplace/actions/sql-review --- .github/workflows/sql-review.yml | 18 ++++++++++++++++++ .github/workflows/stale.yml | 27 --------------------------- sql-review-override.yml | 13 +++++++++++++ 3 files changed, 31 insertions(+), 27 deletions(-) create mode 100644 .github/workflows/sql-review.yml delete mode 100644 .github/workflows/stale.yml create mode 100644 sql-review-override.yml diff --git a/.github/workflows/sql-review.yml b/.github/workflows/sql-review.yml new file mode 100644 index 00000000..bf216713 --- /dev/null +++ b/.github/workflows/sql-review.yml @@ -0,0 +1,18 @@ +# https://github.com/marketplace/actions/sql-review + +name: SQL Review + +on: [pull_request] + +jobs: + sql-review: + runs-on: ubuntu-latest + name: SQL Review + steps: + - uses: actions/checkout@v3 + - name: Check SQL + uses: bytebase/sql-review-action@main + with: + database-type: MYSQL + file-pattern: ^sql/.*\.sql$ + override-file-path: ./sql-review-override.yml diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml deleted file mode 100644 index fb7706c6..00000000 --- a/.github/workflows/stale.yml +++ /dev/null @@ -1,27 +0,0 @@ -# This workflow warns and then closes issues and PRs that have had no activity for a specified amount of time. -# -# You can adjust the behavior by modifying this file. -# For more information, see: -# https://github.com/actions/stale -name: Mark stale issues and pull requests - -on: - schedule: - - cron: '45 15 * * *' - -jobs: - stale: - - runs-on: ubuntu-latest - permissions: - issues: write - pull-requests: write - - steps: - - uses: actions/stale@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - stale-issue-message: 'Stale issue message' - stale-pr-message: 'Stale pull request message' - stale-issue-label: 'no-issue-activity' - stale-pr-label: 'no-pr-activity' diff --git a/sql-review-override.yml b/sql-review-override.yml new file mode 100644 index 00000000..274caaff --- /dev/null +++ b/sql-review-override.yml @@ -0,0 +1,13 @@ +template: bb.sql-review.prod +ruleList: + - type: naming.index.pk + level: WARNING + - type: naming.index.fk + level: WARNING + - type: naming.index.uk + payload: + format: "^idx_{{table}}_unique_{{column_list}}$" + - type: column.no-null + level: WARNING + - type: table.no-foreign-key + level: DISABLED