Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not enable ora when detail enable #187

Merged
merged 1 commit into from
Jan 25, 2017
Merged

fix: should not enable ora when detail enable #187

merged 1 commit into from
Jan 25, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 25, 2017 •
edited
Loading

sindresorhus/ora#27

This change is Reviewable

@fengmk2 fengmk2 added the bug label Jan 25, 2017
@fengmk2
Copy link
Member Author

fengmk2 commented Jan 25, 2017

image

image

@fengmk2
Copy link
Member Author

fengmk2 commented Jan 25, 2017

@afc163 ora 还有一个潜在 bug 没解，就是 start stop 之后，会导致进程的 exit code 被覆盖。sindresorhus/ora#27

@fengmk2 fengmk2 merged commit d6b3d32 into master Jan 25, 2017
@fengmk2 fengmk2 deleted the fix-ora branch January 25, 2017 06:12
@fengmk2
Copy link
Member Author

fengmk2 commented Jan 25, 2017

2.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fengmk2