cnf_manager: Refactor sample_setup #2050
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstennbl
requested review from
denverwilliams,
wvwatson and
agentpoyo
as code owners
|
In my opinion - changes are simple enough to be coupled together like this. |
martin-mat
requested changes
Jun 10, 2024
Change instalation time measurement method to reduce complexity Extract waiting for all resources and liveness_time calculation Extract elapsed time config map creation Add comments as markers for different stages of sample setup Refs: cnti-testcatalog#2036 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
kosstennbl
force-pushed
the
sample-setup-refactor
branch
from
c5441b0
to
d01bf31
Compare
|
Added comment to the referenced issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change instalation time measurement method to reduce complexity Extract waiting for all resources and liveness_time calculation Extract elapsed time config map creation
Add comments as markers for different stages of sample setup
Markers are to be removed once method is simplified enough.
Issues:
Refs: #2036
How has this been tested:
Successfully built
Types of changes:
Refactor
Checklist:
Documentation
No documentation updates required.