-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installation: CNF Installation (6) New installation process #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75b78ff
to
f37ad11
Compare
cadd1cf
to
e432397
Compare
svteb
reviewed
Oct 24, 2024
src/tasks/utils/cnf_installation/deployment_management/helm_deployment_manager.cr
Show resolved
Hide resolved
src/tasks/utils/cnf_installation/deployment_management/helm_deployment_manager.cr
Show resolved
Hide resolved
src/tasks/utils/cnf_installation/deployment_management/helm_deployment_manager.cr
Outdated
Show resolved
Hide resolved
src/tasks/utils/cnf_installation/deployment_management/helm_deployment_manager.cr
Outdated
Show resolved
Hide resolved
src/tasks/utils/cnf_installation/deployment_management/helm_deployment_manager.cr
Show resolved
Hide resolved
cb63195
to
23c26e0
Compare
4 tasks
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
23c26e0
to
c449715
Compare
martin-mat
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
svteb
approved these changes
Nov 7, 2024
collivier
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain.
Don't replace the old one yet, both installation methods should exist simultaneously
Issues:
Refs: #2161