Test Adaptations: CNF Installation (5.3) Disable new cluster tests and adapt service_discovery #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-mat
requested changes
Oct 21, 2024
kosstennbl
force-pushed
the
#2153-disable-new-cluster-tests
branch
from
c26e0ae
to
1b512d7
Compare
svteb
reviewed
Oct 24, 2024
spec/workload/compatibility_spec.cr
Outdated
| @@ -25,7 +25,8 @@ describe "Compatibility" do | |||
| retries = retries + 1 | |||
| end | |||
| Log.info { "Status: #{result[:output]}" } | |||
| (/(PASSED).*(CNF compatible with both Calico and Cilium)/ =~ result[:output]).should_not be_nil | |||
| (/(SKIPPED)).*(alpha_k8s_apis test was temporarily disabled due to needed redesign for cnf_to_new_cluster)/ =~ result[:output]).should_not be_nil | |||
There was a problem hiding this comment.
The message is incorrect, this test is not related to alpha_k8s_apis.
kosstennbl
force-pushed
the
#2153-disable-new-cluster-tests
branch
from
1b512d7
to
669a758
Compare
svteb
approved these changes
Oct 31, 2024
kosstennbl
force-pushed
the
#2153-disable-new-cluster-tests
branch
from
669a758
to
de31311
Compare
Temporarily disable cnf_to_new_cluster tests as this process needs to be redesigned to new installation format. Also, adapt service_discovery to namespaced manifest generation. Refs: #2153 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
kosstennbl
force-pushed
the
#2153-disable-new-cluster-tests
branch
from
de31311
to
26537d3
Compare
4 tasks
collivier
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporarily disable cnf_to_new_cluster tests as this process needs to be redesigned to new installation format.
Also, adapt service_discovery to namespaced manifest generation.
Issues:
Refs: #2153