Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of HeightField #251

Merged
merged 46 commits into from
Jan 25, 2022
Merged

Add support of HeightField #251

merged 46 commits into from
Jan 25, 2022

Conversation

jcarpent
Copy link
Contributor

No description provided.

jmirabel
jmirabel reviewed Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jmirabel jmirabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the large PR. I made some comments and suggestions.

src/BVH/BV_fitter.cpp Outdated Show resolved Hide resolved
src/collision_func_matrix.cpp Show resolved Hide resolved
src/distance_func_matrix.cpp Outdated Show resolved Hide resolved
src/hfield.cpp Show resolved Hide resolved
include/hpp/fcl/data_types.h Outdated Show resolved Hide resolved
test/hfields.cpp Outdated Show resolved Hide resolved
include/hpp/fcl/internal/traversal_node_hfield_shape.h Outdated Show resolved Hide resolved
include/hpp/fcl/internal/traversal_node_hfield_shape.h Outdated Show resolved Hide resolved
include/hpp/fcl/internal/traversal_node_hfield_shape.h Show resolved Hide resolved
include/hpp/fcl/hfield.h Show resolved Hide resolved
jcarpent
jcarpent commented Nov 12, 2021
View reviewed changes
Copy link
Contributor Author

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmirabel for this deep review of the code. I will handle the remaining remarks on the doc after your replies.

@jcarpent
Copy link
Contributor Author

I have handled all the comments. I think we can merge after CI is green.

@jcarpent
all: more warning fixes
66074bf
@jcarpent
types: add Quadrilateral face
9c5bdbe
@jcarpent
BV: add update method to AABB
64f6566
@jcarpent
BV: fix conversion from AABB to OBB
e227962
@jcarpent
doc/BVHModel: enhancement
92a7902
@jcarpent
core: add Matrix typedef
cd0e865
@jcarpent
all: fix warnings
5ca2cc3
@jcarpent
python: fix doc
cc6ac1d
@jcarpent
BV: enhance computations
a777a87
@jcarpent
python: fix doc
6748b6d
@jcarpent
core: replace std::cerr with HPP_FCL_THROW_PRETTY
39dcd0e
@jcarpent
core: comment useless variables
91eed5d
@jcarpent
core: refactoring (minor)
fb165d1
@jcarpent
core: add HeightField
6fc5c34
@jcarpent
core: use noalias()
4282888
@jcarpent
serialization: support HeightField
a6d8f93
@jcarpent
cmake: add missing file
7a34cbb
@jcarpent
python: expose HeightField
37474f4
@jcarpent
test: add basic tests for HeightField
649df58
@jcarpent
test/serialization: add test for HeightField
7ccb129
@jcarpent
core: fix warning
e1f3d4c
@jcarpent
core: fix bug
c43a2dd
@jcarpent
core: fix missing cases
8a42dcb
@jcarpent
hfield: use copy constructor for clone
47b712d
@jcarpent
core: start implementing the support of Distance computations for HFIELD
02005d2
jcarpent and others added 21 commits January 25, 2022 16:26
@jcarpent
traversal: minor fix
b4c01da
@jcarpent
core: fix bugs
9ad539f
@jcarpent
hfield: fix bug
c67f9df
@jcarpent
hfield: relies on Triangle for collision detection of Leaves
cb563df
@jcarpent
test/hfield: enhance testing
d9d7f1b
@jcarpent
hfield: small fix
c0e1fd2
@jcarpent
core: remove useless std::cout
a3fd04e
@jcarpent
hfield: add destructor to HFNode<BV>
7a4b872 
Fix Windows issue
@jcarpent @jmirabel
Update src/distance_func_matrix.cpp
040419d 
Co-authored-by: Joseph Mirabel <josephmirabel@gmail.com>
@jcarpent @jmirabel
Update src/BVH/BV_fitter.cpp
293b024 
Co-authored-by: Joseph Mirabel <josephmirabel@gmail.com>
@jcarpent @jmirabel
Update include/hpp/fcl/internal/traversal_node_hfield_shape.h
52f49df 
Co-authored-by: Joseph Mirabel <josephmirabel@gmail.com>
@jcarpent @jmirabel
Update include/hpp/fcl/data_types.h
b94d191 
Co-authored-by: Joseph Mirabel <josephmirabel@gmail.com>
@jcarpent
core: simplify code
1677f8c
@jcarpent
doc: improve documentation for Height Field
9c7b211
@jcarpent
doc/hfield: add more internal info for design choices
be2b3dd
@jcarpent
core: add set method for Convex
ab3f2b7
@jcarpent
core: fix init of ConvexBase
726564e
@jcarpent
core/hfield: use set instead of creating new objects
c9751ab
@jcarpent
test/hfield: remove useless cout
a1a00b4
@jcarpent
test/hfield: add more tests
72a522a
@jcarpent
core: fix deletion order
a3f9b43
@jcarpent jcarpent merged commit 304b088 into coal-library:devel Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmirabel jmirabel jmirabel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcarpent @jmirabel