update default C++ to 14 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid hundreds of boost 1.81 warnings: > #warning "The minimum language standard to use Boost.Math will be C++14 starting in July 2023 (Boost 1.82 release)" Also, there shouldn't be much use cases where C++11 is available and C++14 is not.
jcarpent
suggested changes
Apr 28, 2023
|
@wxmerkt It seems the ROS CI is failing (similarly to Pinocchio). Could you help us on it? |
nim65s
commented
Apr 29, 2023
Co-authored-by: Guilhem Saurel <guilhem.saurel@laas.fr>
|
I think we could merge this, and fix ROS-CI in another PR, especially because this other issues hits other repositories |
|
The problems with ROS-CI were due to unavailability of the EigenPy binary on Rolling - this issue was temporary (RAM exhaustion) and has been resolved. I restarted the jobs so hopefully they should come back green now |
jcarpent
approved these changes
Apr 30, 2023
nim65s
added a commit
to nim65s/pinocchio
that referenced
this pull request
May 3, 2023
jcarpent
pushed a commit
to nim65s/pinocchio
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid hundreds of boost 1.81 warnings:
Also, there shouldn't be much use cases where C++11 is available and C++14 is not.