From cd0b76b59067e2ecbbe789b2b538810b8e1a5812 Mon Sep 17 00:00:00 2001
From: Marek Libra <mlibra@redhat.com>
Date: Thu, 31 May 2018 08:43:44 +0200
Subject: [PATCH] kubernetes: fix propTypes in React code
---
.../virtual-machines/components/VmDisksTabKubevirt.jsx | 2 +-
.../scripts/virtual-machines/components/VmMessage.jsx | 2 +-
.../scripts/virtual-machines/components/VmsListing.jsx | 8 ++++----
.../scripts/virtual-machines/components/VmsListingRow.jsx | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/pkg/kubernetes/scripts/virtual-machines/components/VmDisksTabKubevirt.jsx b/pkg/kubernetes/scripts/virtual-machines/components/VmDisksTabKubevirt.jsx
index ea0d0c7eccb4..58312d22dbe2 100644
--- a/pkg/kubernetes/scripts/virtual-machines/components/VmDisksTabKubevirt.jsx
+++ b/pkg/kubernetes/scripts/virtual-machines/components/VmDisksTabKubevirt.jsx
@@ -115,7 +115,7 @@ const VmDisksTabKubevirt = ({ vm, pvs }: { vm: Vm, pvs: Array<PersistenVolume> }
VmDisksTabKubevirt.propTypes = {
vm: PropTypes.object.isRequired,
- pvs: PropTypes.object.isRequired,
+ pvs: PropTypes.array.isRequired,
};
export default VmDisksTabKubevirt;
diff --git a/pkg/kubernetes/scripts/virtual-machines/components/VmMessage.jsx b/pkg/kubernetes/scripts/virtual-machines/components/VmMessage.jsx
index fad55abe4c6a..e93c9e31e43c 100644
--- a/pkg/kubernetes/scripts/virtual-machines/components/VmMessage.jsx
+++ b/pkg/kubernetes/scripts/virtual-machines/components/VmMessage.jsx
@@ -44,7 +44,7 @@ const VmMessage = ({ vm, vmMessages, onDismiss }: { vm: Vm, vmMessages: VmMessag
VmMessage.propTypes = {
vm: PropTypes.object.isRequired,
- vmMessages: PropTypes.object.isRequired,
+ vmMessages: PropTypes.object,
onDismiss: PropTypes.func.isRequired,
};
diff --git a/pkg/kubernetes/scripts/virtual-machines/components/VmsListing.jsx b/pkg/kubernetes/scripts/virtual-machines/components/VmsListing.jsx
index f88f50395363..4f9539e442c1 100644
--- a/pkg/kubernetes/scripts/virtual-machines/components/VmsListing.jsx
+++ b/pkg/kubernetes/scripts/virtual-machines/components/VmsListing.jsx
@@ -37,7 +37,7 @@ const VmsListing = ({ vms, pvs, pods, settings, vmsMessages }) => {
pvs={pvs}
key={vm.metadata.uid} />));
let actions = [(
- <CreateVmButton />
+ <CreateVmButton key='create-vm' />
)];
return (
@@ -51,9 +51,9 @@ const VmsListing = ({ vms, pvs, pods, settings, vmsMessages }) => {
};
VmsListing.propTypes = {
- vms: PropTypes.object.isRequired,
- pvs: PropTypes.object.isRequired,
- pods: PropTypes.object.isRequired,
+ vms: PropTypes.array.isRequired,
+ pvs: PropTypes.array.isRequired,
+ pods: PropTypes.array.isRequired,
vmsMessages: PropTypes.object.isRequired,
};
diff --git a/pkg/kubernetes/scripts/virtual-machines/components/VmsListingRow.jsx b/pkg/kubernetes/scripts/virtual-machines/components/VmsListingRow.jsx
index 484e9cca1a03..f41b3f9bd2ab 100644
--- a/pkg/kubernetes/scripts/virtual-machines/components/VmsListingRow.jsx
+++ b/pkg/kubernetes/scripts/virtual-machines/components/VmsListingRow.jsx
@@ -64,7 +64,7 @@ const VmsListingRow = ({ vm, vmMessages, pvs, pod, vmUi, onExpandChanged }:
phase // phases description https://github.com/kubevirt/kubevirt/blob/master/pkg/api/v1/types.go
]}
tabRenderers={[ overviewTabRenderer, disksTabRenderer ]}
- listingActions={<VmActions vm={vm} />}
+ listingActions={[ <VmActions vm={vm} /> ]}
expandChanged={onExpandChanged(vm)}
initiallyExpanded={initiallyExpanded} />
);
@@ -72,7 +72,7 @@ const VmsListingRow = ({ vm, vmMessages, pvs, pod, vmUi, onExpandChanged }:
VmsListingRow.propTypes = {
vm: PropTypes.object.isRequired,
- vmMessages: PropTypes.object.isRequired,
+ vmMessages: PropTypes.object,
pvs: PropTypes.array.isRequired,
pod: PropTypes.object.isRequired,
vmUi: PropTypes.object,