Add onSortTable handler for StatementsPage #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When StatementsPage component was extracted, analytics tracking functionality which was embedded into component has been removed and should be handled outside of component (with respective callback functions). `trackTableSort` tracking function was missed. To make it work, `onSortingChange` prop is added to handle it outside. Also unnecessary `refreshDiagnosticsReports` is removed because it duplicates already existing `refreshStatementDiagnosticsRequests` prop.
ColumnDescriptor configuration provides information about existing columns in table. The issue appeared when user sorts data by some column and it is necessary to know column name (to send it as part of analytics data). Previously, `title` column was used for this purpose, but the problem is that `title` field is ReactNode, not string. It means, after casting field to string - it always has [object Object] value instead of meaningful column name. With current change, ColumnDescriptor configuration is extended with extra string field "name" as unique column name.
dhartunian
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cockroachdb/cockroach#51910 (comment)
When StatementsPage component was extracted, analytics tracking
functionality which was embedded into component has been removed and
should be handled outside of component (with respective callback
functions).
trackTableSorttracking function was missing. To make it work,onSortingChangeprop is added to handle it outside.ColumnDescriptor configuration provides information about existing
columns in the table. The issue appeared when a user sorts data by some
column and it is necessary to know column name (to send it as part
of analytics data). Previously,
titlecolumn was used for thispurpose, but the problem is that
titlefield is ReactNode, not string.It means, after casting field to string - it always has [object Object]
value instead of a meaningful column name.
With the current change, ColumnDescriptor configuration is extended with
extra string field "name" as unique column name.