-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
changefeedccl: refactor parquet column iterators
Previously, some tests would fail due to invalid conversion from parquet to JSON in testing. These failures showed two underlying issues with how columns were written: - in tests watching a column family not containing the primary key of the table, we would not write the primary key to the parquet file - in tests where the primary key was defined with a particular order which is different than the table, the parquet testing code would not order the keys correctly This change fixes the two above issues by (a) using the correct iterators on `cdcevent.Row` and writing more verbose metadata to the parquet file to use in testing. Epic: None Release note: None
- Loading branch information
1 parent
29efad7
commit 875cbfa
Showing
3 changed files
with
133 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters