From cbdb1deebdbf4aa2482c755ee54e7376e88edf1c Mon Sep 17 00:00:00 2001 From: Rail Aliiev Date: Tue, 31 Oct 2023 16:31:21 +0000 Subject: [PATCH] bincheck: bind 127.0.0.1 Previously, bincheck started a single node database instance without specifying the address/port it listens on. In this case the server code tried to resolve the hostname and use it. See https://github.com/cockroachdb/cockroach/blob/d498a59cc2afc9778af6f7e0120206ab1ee56bc2/pkg/base/addr_validation.go#L128 for the details. At some point this method stopped working on MacOS GitHub workers. There is an upstream issue open: https://github.com/actions/runner-images/issues/8649 This PR explicitly sets the `--listen-addr` parameter to skip the problematic code. Epic: none Release note: None --- build/release/bincheck/bincheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/release/bincheck/bincheck b/build/release/bincheck/bincheck index 2ab7178c9b4b..97e7693cc5cb 100755 --- a/build/release/bincheck/bincheck +++ b/build/release/bincheck/bincheck @@ -32,7 +32,7 @@ echo "Generating encryption key:" echo "" # Start node with encryption enabled. -"$cockroach" start-single-node --insecure --listening-url-file="$urlfile" --enterprise-encryption=path=cockroach-data,key=aes-128.key,old-key=plain --pid-file="$pidfile" & +"$cockroach" start-single-node --listen-addr 127.0.0.1:26257 --insecure --listening-url-file="$urlfile" --enterprise-encryption=path=cockroach-data,key=aes-128.key,old-key=plain --pid-file="$pidfile" & trap "kill -9 $! || true" EXIT for i in {0..8}