Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/must: better formatting for Equal() #107777

Closed
erikgrinaker opened this issue Jul 28, 2023 · 2 comments
Closed

util/must: better formatting for Equal() #107777

erikgrinaker opened this issue Jul 28, 2023 · 2 comments
Assignees
@erikgrinaker
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@erikgrinaker
Copy link
Contributor

It would be nice to print e.g. a diff when must.Equal() fails on large structs.
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Jul 28, 2023
@erikgrinaker erikgrinaker self-assigned this Jul 28, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 28, 2023

cc @cockroachdb/test-eng

@erikgrinaker erikgrinaker mentioned this issue Jul 28, 2023
Merged
@erikgrinaker
Copy link
Contributor Author

must is no more, see #108272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Test Engineering
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikgrinaker