schemachanger: support configure zone discard for zone configs #133157
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
annrpom
added
C-enhancement
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 23, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 23, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 23, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 24, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 24, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 28, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 28, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 30, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 30, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
craig bot
pushed a commit
that referenced
this issue
Oct 30, 2024
132967: schemachanger: add support discarding database/table zc r=rafiss a=annrpom ### scbuild: version gate SetZoneConfig with isV243Active New support was added in 24.3 in `SetZoneConfig` for subzone configs. Since this work was a significant change, we should gate `SetZoneConfig` to minimize the risk of compatibility issues with earlier versions. Epic: none Release note: None --- ### schemachanger: re-enable dsc zone config Since 24.3 has been cut, we can turn zone configs on in the declarative schema changer by default. Epic: none Release note: None --- ### scexec: extend UpdateZoneConfig to allow for deletes This patch extends UpdateZoneConfig to allow for deletes in the system.zones table. Epic: None Release note: None --- ### scbuildstmt: refactor zoneConfigObjBuilder method This patch refactors the `addZoneConfigToBuildCtx` method of our `zoneConfigObjBuilder` to be less specific; we pull the `b.add` out so that we can decide in `SetZoneConfig` whether to add or drop this element. Epic: none Release note: None --- ### schemachanger: add support discarding database/table zc This patch supports discarding a database/table zone config in the declarative schema changer. Informs: #133157 Release note: None 133725: kvserver/rangefeed: add metric for processor-level send timeout r=wenyihu6a a=stevendanna Epic: none Release note: None 133848: bazel-github-helper: sort list of failed tests in summary r=rail a=rickystewart Epic: CRDB-17171 Release note: None Release justification: Non-production code changes 133874: raft: don't panic on defortifying snapshot from new term r=nvanbenschoten a=nvanbenschoten Informs #132762. This commit fixes a bug introduced by 58a9f53. Now that we no longer assume that snapshots are coming from the leader, we were not defortifying the raft leadership when receiving a snapshot. This meant that if a snapshot came from a new term, we would hit an assertion failure, which the new test reproduces. This commit addresses this bug by distinguishing between messages that are always sent from the leader of the message's term and messages that indicate that there is a new leader of the message's term, even if the message is not from the leader itself. This is temporary, and can be removed when we address #127349. Release note: None 133878: revert "logictest: deflake TestLogic_union" r=yuzefovich a=yuzefovich This reverts commit 6218f23. I don't think this commit did anything to remove or reduce flakiness in the union logic test because the error occurs on the SELECT query _after_ the DDL and DML statements modified by this commit. Reverting it to allow for cleaner backports. Epic: None Release note: None Co-authored-by: Annie Pompa <annie@cockroachlabs.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Oct 31, 2024
This patch supports discarding a database/table zone config in the declarative schema changer. Informs: cockroachdb#133157 Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Nov 25, 2024
This patch removes the fallback to legacy schema changer path we have for discarding named ranges. This includes ensuring we block the ability to discard the system range. Fixes: cockroachdb#133157 Epic: none Release note: None
annrpom
added a commit
to annrpom/cockroach
that referenced
this issue
Nov 25, 2024
This patch removes the fallback to legacy schema changer path we have for discarding named ranges. This includes ensuring we block the ability to discard the system range. Fixes: cockroachdb#133157 Epic: none Release note: None
craig bot
pushed a commit
that referenced
this issue
Nov 25, 2024
135909: schemachanger: remove discard named range fallback r=annrpom a=annrpom This patch removes the fallback to legacy schema changer path we have for discarding named ranges. This includes ensuring we block the ability to discard the system range. Fixes: #133157 Epic: none Release note: None Co-authored-by: Annie Pompa <annie@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue tracks our progress of supporting zone configs in declarative schema changer; in particular, this tracks support for
ALTER { RANGE | DATABASE | TABLE } ... CONFIGURE ZONE DISCARDin the declarative schema changer.Jira issue: CRDB-43481
Epic CRDB-43532
The text was updated successfully, but these errors were encountered: