Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: Raft propagation of closed timestamps #57396

Closed
andreimatei opened this issue Dec 2, 2020 · 1 comment
Closed

kvserver: Raft propagation of closed timestamps #57396

andreimatei opened this issue Dec 2, 2020 · 1 comment
Assignees
Labels
A-kv-closed-timestamps Relating to closed timestamps A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@andreimatei
Copy link
Contributor

The closed timestamps v2 RFC wants closed timestamp information to be carried to follower on Raft entries, under the RangeAppliedStateKey.

A prototype from @nvanbenschoten in nvanbenschoten@abd907f

Lease requests are a special case in that the lease start time acts as a closed ts.

@andreimatei andreimatei added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multiregion Related to multi-region A-kv-closed-timestamps Relating to closed timestamps labels Dec 2, 2020
@andreimatei andreimatei self-assigned this Dec 2, 2020
andreimatei added a commit to andreimatei/cockroach that referenced this issue Feb 18, 2021
This patch introduces a replacement for the existing closed timestamp
mechanism / transport. The new mechanism is gated by a cluster version.

Raft commands now carry increasing closed timestamps generated by the
propBuf by using the recent request Tracker for synchronizing with
in-flight requests (i.e. not closing timestamps below them).
Raft commands get a closed ts field, and the range state gets the field
as well.

The propBuf pays attention to the range's closed timestamp policy for
deciding whether to close lagging or leading timestamps.

Fixes cockroachdb#57395, cockroachdb#57396
Touches cockroachdb#57405

Release note: None
andreimatei added a commit to andreimatei/cockroach that referenced this issue Feb 18, 2021
This patch introduces a replacement for the existing closed timestamp
mechanism / transport. The new mechanism is gated by a cluster version.

Raft commands now carry increasing closed timestamps generated by the
propBuf by using the recent request Tracker for synchronizing with
in-flight requests (i.e. not closing timestamps below them).
Raft commands get a closed ts field, and the range state gets the field
as well.

The propBuf pays attention to the range's closed timestamp policy for
deciding whether to close lagging or leading timestamps.

Fixes cockroachdb#57395, cockroachdb#57396
Touches cockroachdb#57405

Release note: None
andreimatei added a commit to andreimatei/cockroach that referenced this issue Feb 20, 2021
This patch introduces a replacement for the existing closed timestamp
mechanism / transport. The new mechanism is gated by a cluster version.

Raft commands now carry increasing closed timestamps generated by the
propBuf by using the recent request Tracker for synchronizing with
in-flight requests (i.e. not closing timestamps below them).
Raft commands get a closed ts field, and the range state gets the field
as well.

The propBuf pays attention to the range's closed timestamp policy for
deciding whether to close lagging or leading timestamps.

Fixes cockroachdb#57395, cockroachdb#57396
Touches cockroachdb#57405

Release note: None
@nvanbenschoten
Copy link
Member

Fixed by #59566.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-closed-timestamps Relating to closed timestamps A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

3 participants