Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest/sqlsmith: unsupported SQLSmith type kind #90010

Closed
cockroach-teamcity opened this issue Oct 14, 2022 · 2 comments · Fixed by #90221
Closed

roachtest/sqlsmith: unsupported SQLSmith type kind #90010

cockroach-teamcity opened this issue Oct 14, 2022 · 2 comments · Fixed by #90221
Assignees
@rytaft
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 14, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.unoptimized-query-oracle/disable-rules=half/seed-multi-region failed with artifacts on master @ d6c28f56d38c747dbd6fc64359e6255c873083c5:

test artifacts and logs in: /artifacts/unoptimized-query-oracle/disable-rules=half/seed-multi-region/run_1
(query_comparison_util.go:263).newMutatingSmither: unsupported SQLSmith type kind

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-20544
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Oct 14, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Oct 14, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Oct 14, 2022
@DrewKimball
Copy link
Collaborator

I don't see an obvious way to find what caused this; the action item here might just be to make the error more useful.

@rytaft rytaft removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Oct 17, 2022
@rytaft
Copy link
Collaborator

rytaft commented Oct 17, 2022

Removing release blocker label -- this is a test infra issue.

@DrewKimball DrewKimball changed the title roachtest: unoptimized-query-oracle/disable-rules=half/seed-multi-region failed roachtest/sqlsmith: unsupported SQLSmith type kind Oct 18, 2022
@DrewKimball DrewKimball mentioned this issue Oct 18, 2022
Closed
@rytaft rytaft mentioned this issue Oct 19, 2022
Merged
craig bot pushed a commit that referenced this issue Oct 19, 2022
@rytaft
Merge #90221
1d9c9a6 
90221: roachtest: fix costfuzz and unoptimized-query-oracle setups r=rytaft a=rytaft

This commit fixes a bug that was recently introduced when registering the costfuzz and unoptimized-query-oracle tests. This bug was due to the well-known range loop variable issue described here: golang/go#20733.

This commit also adds some additional logging and debug information to help with future issues with these test cases.

Fixes #90010

Release note: None

Co-authored-by: Rebecca Taft <becca@cockroachlabs.com>
@craig craig bot closed this as completed in f353458 Oct 19, 2022
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rytaft rytaft

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
22.2
Development

Successfully merging a pull request may close this issue.

roachtest: fix costfuzz and unoptimized-query-oracle setups rytaft/cockroach
3 participants
@rytaft @cockroach-teamcity @DrewKimball