Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "do not merge: always force parquet format in cdc tests" #103928

Merged
merged 2 commits into from
Jun 1, 2023

Commits on May 25, 2023

  1. Revert "do not merge: always force parquet format in cdc tests if pos…

    …sible"
    
    This reverts commit 63eccd4.
    
    Release note: None
    Epic: None
    jayshrivastava committed May 25, 2023
    Configuration menu
    Copy the full SHA
    29efad7 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. changefeedccl: refactor parquet column iterators

    Previously, some tests would fail due to invalid conversion
    from parquet to JSON in testing. These failures showed two
    underlying issues with how columns were written:
    - in tests watching a column family not containing the primary
      key of the table, we would not write the primary key to
      the parquet file
    - in tests where the primary key was defined with a particular
      order which is different than the table, the parquet testing
      code would not order the keys correctly
    
    This change fixes the two above issues by (a) using the correct
    iterators on `cdcevent.Row` and writing more verbose
    metadata to the parquet file to use in testing.
    
    Epic: None
    Release note: None
    jayshrivastava committed May 31, 2023
    Configuration menu
    Copy the full SHA
    875cbfa View commit details
    Browse the repository at this point in the history