Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: support the updated and mvcc with parquet format #104407

Merged
merged 2 commits into from
Jun 7, 2023
Merged

changefeedccl: support the updated and mvcc with parquet format #104407

merged 2 commits into from
Jun 7, 2023

Commits on Jun 6, 2023

  1. changefeedccl: use buildutil.CrdbTestBuild for parquet testing 

    Parquet testing requires that extra metadata be written to parquet files
so tests can create CDC rows from the raw data. Previously, the production
parquet code relied on a testing knob to be passed to write this extra
metadata. This is problematic as not all tests would pass the testing knob,
making it so that we could not randomly use parquet in those tests for
metamorphic testing purposes. With this change, the parquet production code
uses `buildutil.CrdbTestBuild`, which is a global flag enabled in tests.
Now, metamorphic parquet testing can be applied to more tests.

Epic: None
Release note: None
    @jayshrivastava
    jayshrivastava committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b050218 View commit details
    Browse the repository at this point in the history

  2. changefeedccl: support the updated and mvcc timestamp options with pa… 

    …rquet format

Previously, using the parquet format in changefeeds did not support
using the `mvcc` or `updated` options. This change adds support for using
these options with parquet.

Epic: None
Release note: None
    @jayshrivastava
    jayshrivastava committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    3045e41 View commit details
    Browse the repository at this point in the history