From 3f01c79031a5b0440dc086ef97bf2bd8c220492b Mon Sep 17 00:00:00 2001 From: Renato Costa Date: Fri, 15 Dec 2023 21:28:05 +0000 Subject: [PATCH] roachtest: don't run `schemachange` workload with upgrade migrations This has been flaking on all branches. Informs: #116586. Fixes: #116304. Fixes: #116425. Fixes: #116357. Release note: None --- pkg/cmd/roachtest/tests/versionupgrade.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/cmd/roachtest/tests/versionupgrade.go b/pkg/cmd/roachtest/tests/versionupgrade.go index 652100b5c1c6..233f39e28ae5 100644 --- a/pkg/cmd/roachtest/tests/versionupgrade.go +++ b/pkg/cmd/roachtest/tests/versionupgrade.go @@ -145,6 +145,12 @@ func runVersionUpgrade(ctx context.Context, t test.Test, c cluster.Cluster) { mvt.InMixedVersion( "test schema change step", func(ctx context.Context, l *logger.Logger, rng *rand.Rand, h *mixedversion.Helper) error { + // TODO: re-enable once #116586 is addressed. + if h.Context.Finalizing { + l.Printf("schemachange workload has been flaking when run during upgrades; skipping") + return nil + } + randomNode := h.RandomNode(rng, c.All()) // The schemachange workload is designed to work up to one // version back. Therefore, we upload a compatible `workload`