Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: crosscluster/logical: handle user-defined types in SQL mode #133295

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 23, 2024

Backport 2/2 commits from #133280 on behalf of @rafiss.

/cc @cockroachdb/release


This PR also includes a cleanup refactor:

importer,crosscluster: move type resolver to a different package

Since we're using this type resolver for more than just IMPORT, it makes
more sense to put it in a more fitting package.


crosscluster/logical: handle user-defined types in SQL mode

Previously, using a user-defined type in SQL mode would fail because of
a low level check in the execution engine that verifies that the input
datum has the same type OID as the destination column.

This does not work for LDR, since the input datums come directly from a
source table in a different cluster, so user-defined types have
different OIDs.

This fixes it by setting the datum type to "unknown" before executing
the insert query. The "unknown" type is what is normally used when any
SQL statement is sent to CRDB without explicit type annotations/hints.
When the execution engine sees this type, it will perform an automatic
(and cheap) immutable assignment cast to change the datum to the
appropriate type.

fixes #132164
Release note (ops change): Logical replication streams that reference
tables with user-defined types can now be created with the mode = immediate option.


Release justification: resolve a GA blocker

Previously, using a user-defined type in SQL mode would fail because of
a low level check in the execution engine that verifies that the input
datum has the same type OID as the destination column.

This does not work for LDR, since the input datums come directly from a
source table in a different cluster, so user-defined types have
different OIDs.

This fixes it by setting the datum type to "unknown" before executing
the insert query. The "unknown" type is what is normally used when any
SQL statement is sent to CRDB without explicit type annotations/hints.
When the execution engine sees this type, it will perform an automatic
(and cheap) immutable assignment cast to change the datum to the
appropriate type.

Release note (ops change): Logical replication streams that reference
tables with user-defined types can now be created with the `mode =
immediate` option.
Since we're using this type resolver for more than just IMPORT, it makes
more sense to put it in a more fitting package.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 23, 2024 19:57
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-133280 branch from a0605fe to ee1a856 Compare October 23, 2024 19:57
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 23, 2024 19:57
@blathers-crl blathers-crl bot requested review from jeffswenson and removed request for a team October 23, 2024 19:57
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 23, 2024
@blathers-crl blathers-crl bot requested review from rytaft and removed request for a team October 23, 2024 19:57
Copy link
Author

blathers-crl bot commented Oct 23, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 23, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested review from a team and removed request for rytaft and mgartner October 23, 2024 20:12
@rafiss rafiss merged commit 183bed7 into release-24.3 Oct 23, 2024
20 of 21 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.3-133280 branch October 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants