kvserver: register MultiRaft service with DRPC server
#146926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdhama
requested review from
alyshanjahani-crl
and removed request for
a team
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
shubhamdhama
requested review from
Abhinav1299,
aa-joshi,
arjunmahishi,
kev-cao and
mw5h
and removed request for
a team
Member
|
This change is |
This comment was marked as outdated.
This comment was marked as outdated.
shubhamdhama
requested review from
cthumuluru-crdb
and removed request for
a team,
Abhinav1299,
aa-joshi,
arjunmahishi and
kev-cao
Contributor
Author
|
cthumuluru-crdb
pushed a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 23, 2025
Enable the `Blob` service on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
TheComputerM
pushed a commit
to TheComputerM/cockroach
that referenced
this pull request
Jun 23, 2025
This is a follow-up to cockroachdb#145195, where we extracted `KVBatch` from the `Internal` service. Here, we do the same with `TenantUsage`. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
TheComputerM
pushed a commit
to TheComputerM/cockroach
that referenced
this pull request
Jun 23, 2025
This is a follow-up to cockroachdb#145195, where we extracted `KVBatch` from the `Internal` service. Here, we do the same with `TenantSpanConfig`. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
148500: blobs: register `Blob` service with DRPC server r=cthumuluru-crdb a=shubhamdhama Enable the `Blob` service on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: #146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None Co-authored-by: Shubham Dhama <shubham.dhama@cockroachlabs.com>
cthumuluru-crdb
added a commit
to cthumuluru-crdb/cockroach
that referenced
this pull request
Jun 23, 2025
Enable `DistSQL` and `Tracing` services on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
148657: server: register `DistSQL`, `Tracing` service with DRPC server r=cthumuluru-crdb a=cthumuluru-crdb Enable `DistSQL` and `Tracing` services on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: #146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None 148658: roachtest: more CPU profiling in rebalancing tests r=tbg a=tbg Closes #147487. Co-authored-by: Chandra Thumuluru <chandra.thumuluru@cockroachlabs.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
cthumuluru-crdb
added a commit
to cthumuluru-crdb/cockroach
that referenced
this pull request
Jun 23, 2025
Enable the Init, Migration, KeyVisualizer services on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
148651: server: register Init,Migration,KeyVisualizer services with DRPC server r=cthumuluru-crdb a=cthumuluru-crdb Enable the Init, Migration, KeyVisualizer services on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: #146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None Co-authored-by: Chandra Thumuluru <chandra.thumuluru@cockroachlabs.com>
cthumuluru-crdb
added a commit
to cthumuluru-crdb/cockroach
that referenced
this pull request
Jun 23, 2025
This is a follow-up to cockroachdb#145195, where we extracted KVBatch from the Internal service. Here, we do the same with RangeFeed. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 24, 2025
Enable these service on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 24, 2025
Enable these service on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 24, 2025
Enable these service on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 24, 2025
Enable the `Status` service on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
148584: server: register status, TS, Login/Logout, Admin services with DRPC server r=cthumuluru-crdb,aa-joshi a=shubhamdhama Enable the `Status`, `Login`, `Logout`, `Timeseries`, `Admin` services on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: #146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Fixes: #148721 Fixes: #148722 Fixes: #148724 Fixes: #148723 Epic: CRDB-48925 Release note: None Co-authored-by: Shubham Dhama <shubham.dhama@cockroachlabs.com>
cthumuluru-crdb
added a commit
to cthumuluru-crdb/cockroach
that referenced
this pull request
Jun 24, 2025
This is a follow-up to cockroachdb#145195, where we extracted KVBatch from the Internal service. Here, we do the same with RangeFeed. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 26, 2025
…erver This is a follow-up to cockroachdb#145195, where we extracted `KVBatch` from the `Internal` service. Here, we do the same with `QuorumRecovery`. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Fixes: cockroachdb#148726 Epic: CRDB-48925 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
148785: server,cli: extract `QuorumRecovery` and register with DRPC server r=tbg a=shubhamdhama This is a follow-up to #145195, where we extracted `KVBatch` from the `Internal` service. Here, we do the same with `QuorumService`. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: #146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Fixes: #148726 Epic: CRDB-48925 Release note: None Co-authored-by: Shubham Dhama <shubham.dhama@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable MultiRaft service on the DRPC server in addition to gRPC. Controlled
by
rpc.experimental_drpc.enabled(off by default).To enable this change, we used the interfaces introduced in
cockroachdb/drpc#2. For example, for server-side
stream implementations, we used
RPCMultiRaft_RaftMessageBatchStream,which is the common interface between
DRPCMultiRaft_RaftMessageBatchStream(for DRPC)and
MultiRaft_RaftMessageBatchServer(for gRPC).Note: This only registers the service; the client is not updated to use the
DRPC client, so this service will not have any functional effect.
Fixes: #146473
Epic: CRDB-48925
Release note: None