*: replace grpc clients with rpc adapters #147950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
cthumuluru-crdb
force-pushed
the
use-grpc-drpc-adapters
branch
3 times, most recently
from
095ae83 to
2695c8e
Compare
cthumuluru-crdb
requested review from
Abhinav1299,
DarrylWong,
aa-joshi,
arjunmahishi,
herkolategan,
kev-cao and
kyle-a-wong
and removed request for
a team
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Informs:cockroachdb#148353 Release note: none
cthumuluru-crdb
force-pushed
the
use-grpc-drpc-adapters
branch
from
cbdc938 to
32a4a95
Compare
gRPC and DRPC clients have different signatures. To unify them, a common interface was created for both types of clients, and replaced the gRPC and DRPC clients with adapters. Epic: CRDB-48923 Fixes:cockroachdb#148353 Release note: none
cthumuluru-crdb
force-pushed
the
use-grpc-drpc-adapters
branch
from
32a4a95 to
4930b55
Compare
Contributor
Author
|
bors r+ |
Contributor
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 19, 2025
This change replaces the direct client creation through `NewInternalClient` with the gRPC adapter. See cockroachdb#147950 for more context. Also, since we have a more targeted service for `Join` RPC, we should use its adapter interface. Release note: none Epic: CRDB-48923
craig bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
148451: kv,server: extract `Cluster` service and register with DRPC server r=cthumuluru-crdb a=shubhamdhama `` kv,server: extract `Cluster` service and register with DRPC server `` This is a follow-up to #145195, where we extracted `KVBatch` from the `Internal` service. Here, we do the same with `Cluster`. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: #146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. `` server: replace `RPCClusterClient` for cluster join operation `` This change replaces the direct client creation through `NewInternalClient` with the gRPC adapter. See #147950 for more context. Also, since we have a more targeted service for `Join` RPC, we should use its adapter interface. Release note: none Epic: CRDB-48923 Co-authored-by: Shubham Dhama <shubham.dhama@cockroachlabs.com>
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC and DRPC clients have different signatures. To unify them, we created a common interface for both types of clients, and replaced the gRPC and DRPC clients with adapters.
Epic: CRDB-48923
Informs: #148353
Release note: none