workloadccl: remove stale comment around importing fixtures #148168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deletes now-stale comment that was added in 09abc26. That change made a switch from using IMPORT TABLE to IMPORT INTO for importing fixtures as a temporary workaround. However, since then we completely deprecated IMPORT TABLE syntax, so the only way to import the data now is to create the tables separately, which makes the comment confusing. Release note: None
yuzefovich
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
mgartner
approved these changes
Jun 16, 2025
Collaborator
mgartner
left a comment
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Member
Author
|
Haha, 🦸 ! TFTR! bors r+ |
Contributor
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deletes now-stale comment that was added in 09abc26. That change made a switch from using IMPORT TABLE to IMPORT INTO for importing fixtures as a temporary workaround. However, since then we completely deprecated IMPORT TABLE syntax, so the only way to import the data now is to create the tables separately, which makes the comment confusing.
Epic: None
Release note: None